852229 - Add a comment explaining zones

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

This probably should have been part of the initial checkin. Oh well.

Any ideas to make this clearer would be appreciated. I realize that the comment assumes familiarity with compartments, but that's probably the best thing given what most people looking at the code already know. Maybe we can add a comment about compartments later on that's more free-standing.

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 726255 [details] [diff] [review]
patch

Review of attachment 726255 [details] [diff] [review]:
-----------------------------------------------------------------

Wonderful.

Out of curiosity, why is it necessary that a Zone always has at least one Compartment?

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d75dbe2a4dd7

> Out of curiosity, why is it necessary that a Zone always has at least one Compartment?

It's not really necessary. I just find it easier to reason about stuff if you don't have to think about the case where a zone has no compartments.

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d75dbe2a4dd7