Closed
Bug 852518
Opened 11 years ago
Closed 11 years ago
Reorganize ifdefs and cleanup dtor in vm/ForkJoin.cpp
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: nmatsakis, Unassigned)
References
Details
Attachments
(2 files)
857 bytes,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
4.82 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Peeling off two unrelated patches that are blocking bug 829602 into their own bug.
Reporter | ||
Comment 1•11 years ago
|
||
Attachment #726633 -
Flags: review?(wmccloskey)
Reporter | ||
Comment 2•11 years ago
|
||
Make it clearer what happens JS_THREADSAFE is not enabled, and also do the same when JS_ION is not enabled, since ion is effectively required for any sort of parallel execution.
Attachment #726635 -
Flags: review?(wmccloskey)
Updated•11 years ago
|
Attachment #726633 -
Flags: review?(wmccloskey) → review+
Comment 3•11 years ago
|
||
Comment on attachment 726635 [details] [diff] [review] Adjust ifdef strategy Review of attachment 726635 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/vm/ForkJoin.cpp @@ +19,5 @@ > #endif > > +#if defined(JS_THREADSAFE) && defined(JS_ION) > +# define JS_THREADSAFE_ION > +#endif There's no need for this indirection, just do: #if defined(JS_THREADSAFE) && defineD(JS_ION) real implementation #else dummy implementation #endif
Attachment #726635 -
Flags: review?(wmccloskey) → review+
Reporter | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/51313f09b4da https://hg.mozilla.org/integration/mozilla-inbound/rev/ccb23fd0cfd7
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/51313f09b4da https://hg.mozilla.org/mozilla-central/rev/ccb23fd0cfd7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•