852836 - Front camera preview image upside down

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Dafeng Xu]

Front camera preview image upside down

Comment 1

[Dafeng Xu]

Attachment: camera.js patch

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 727057 [details] [diff] [review]
camera.js patch

I'm f-minusing this patch because it seems to have some extra stuff in it from statusbar.js; also because I think the correct way to address this issue is by specifying a cam.1.sensor_offset value for tara.  See [1] for an example.

1. https://github.com/mozilla-b2g/android-device-unagi/blob/master/full_unagi.mk#L16

Comment 3

[Evelyn Hung]

The problem happens on Helix device.
Per comment 2, ni marco to check the settings in gecko/gonk.
We will also check the code segment in Camera app.

Comment 4

[Marco Chen [:mchen]]

(In reply to Mike Habicher [:mikeh] from comment #2)
> 
> 1.
> https://github.com/mozilla-b2g/android-device-unagi/blob/master/full_unagi.
> mk#L16

Currently we found that property will be used for "takePicture" only not for preview.
And we are digging to the flow of rotation on case of preview.

Comment 5

[Marco Chen [:mchen]]

And camera.js already set rotation to 90 degree in camera.js.

https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/camera.js#L787

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Patch:
https://github.com/rexboy7/gaia/commit/ed19a5710f10425c9cd7c59e4f75a9c68e5ace47

This is more like a regression because |camera| is an object which can never equals to 1. When it works correctly, the preview for front camera is flipped upside-down and mirrored, which is exactly what we want.

Seems Gaia flips the preview for front camera since very long ago. I'm not sure whether this should be done in Gaia or Gecko though.

Comment 7

[Dale Harvey (:daleharvey)]

The code referenced for the regression should most definitely be taken out, however the current code works on the peak (I will hopefully be able to test with an sgs2 shortly) 

So I suspect we should be fixing this as mikeh referenced with cam.1.sensor_offset fixes

Comment 8

[Marco Chen [:mchen]]

(In reply to Dale Harvey (:daleharvey) from comment #7)
> So I suspect we should be fixing this as mikeh referenced with
> cam.1.sensor_offset fixes

Please refer to comment 4 for the usage of cam.x.sensor_offset currently.
It seems to not related to preview.

Comment 9

[Evelyn Hung]

(In reply to KM Lee [:rexboy] from comment #6)
> Patch:
> https://github.com/rexboy7/gaia/commit/
> ed19a5710f10425c9cd7c59e4f75a9c68e5ace47
> 
> This is more like a regression because |camera| is an object which can never
> equals to 1. When it works correctly, the preview for front camera is
> flipped upside-down and mirrored, which is exactly what we want.
> 
> Seems Gaia flips the preview for front camera since very long ago. I'm not
> sure whether this should be done in Gaia or Gecko though.

Discussed with Marco offline, we think the flip work in Gaia is reasonable.
I test the patch and it works, so if it get r+ from reviewer, we can merge it and close this issue.
Rex, please set review flag to a proper reviewer. Thanks.

Comment 10

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Per Comment #9, let's try on this patch.
I've tested it on the target device and it works well.
Dale, may you help review it? Thank you!

Comment 11

[Dale Harvey (:daleharvey)]

Merged in: https://github.com/mozilla-b2g/gaia/commit/8012351787d24bfcbf21126aeca9eb4803675af0

Thanks, So the peak branch I was testing (v1.0.1) didnt have this regression, master did though (and this fixed it)

Comment 12

[Evelyn Hung]

Rex: it seems we don't have hd+ triage yet, please help on uplifting this patch to v1.1.0hd. Thanks!

Comment 13

[KM Lee [:rexboy] (inactivate after Sep. 22)]

v1.1.0hd:
https://github.com/mozilla-b2g/gaia/commit/170f62c5451c0de960cf18762a5d673a0b3d8443

Comment 14

[Gareth Aye [:gaye] (back from PTO)]

v1.1.0hd: 036bcaca5ed58dbb0360594a8876cb9819436966
v1.1.0hd: 170f62c5451c0de960cf18762a5d673a0b3d8443

Comment 15

[Wayne Chang [:wchang]]

hd+ as device specific requirement

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 036bcaca5ed58dbb0360594a8876cb9819436966
v1.1.0hd: 170f62c5451c0de960cf18762a5d673a0b3d8443

Comment 17

[William Hsu [:whsu]]

Thanks for your help!
I cannot reproduce this case by following test steps.
 1.Open the camera application.
 2.Switch to the front camera.

* Test build:(Mozilla-b2g18_v1_1_0_hd-helix/2013-08-15-04-22-01)
  + Mercurial-Information
    - Gecko revision="bd0864949c0f"
  + Git-information
    - Gaia revision="d04d2d3969e4366fabafe9659f9b2705b7879ac2"

Marked as "Verified"+"Fixed"