Closed
Bug 85304
Opened 23 years ago
Closed 23 years ago
TLS support broken in mozilla
Categories
(Core Graveyard :: Security: UI, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mscott, Assigned: javi)
References
Details
Attachments
(2 files)
4.09 KB,
patch
|
Details | Diff | Splinter Review | |
4.71 KB,
patch
|
Details | Diff | Splinter Review |
Sometime within the last week or so the TSL socket provided by PSM broke. This prevents users from sending mail using SSL (which is currently the default in mailnews so we are getting tons of complaints about this because people can't send their email). Necko is properly invoking the TSL socket. However, we never receive an OnStartRequest from the tsl socket. Also, it appears that mozilla is incapable of any networking activity after we create a TLS socket. Something is causing everything to get blocked. Seems strange that psm could cause the necko threads to block.
Reporter | ||
Comment 1•23 years ago
|
||
Adding appropriate keywords
Comment 2•23 years ago
|
||
Is this happening on the branch or trunk builds?
Reporter | ||
Comment 3•23 years ago
|
||
trunk only.
Comment 4•23 years ago
|
||
Adding Javi to cc-list. Javi, Is there any chance that your TLS fix may be causing this problem on the trunk?
Assignee | ||
Comment 5•23 years ago
|
||
Someone remind me how to modify my SMTP SSL settings. I can't find it in the UI.
Reporter | ||
Comment 6•23 years ago
|
||
Edit / Mail And News Settings. Then click on Outgoing Server. Check the radio button for "Try SSL when available" thanks for looking into this javi.
Assignee | ||
Comment 7•23 years ago
|
||
Here's what I'm seeing: nsSSLIOLayerNewSocket gets called with the argument to set up a TLS socket. After I return from that function, neither nsSSLIOLayerWrite nor nsNSSSocketInfo::TLSStepUp get called. These are supposed to get called, right?
Reporter | ||
Comment 8•23 years ago
|
||
I'm not sure whose supposed to call nsNSSSocketInfo::TLSStepUp but from the smtp protocol's point of view, we never try to right anything to the socket until necko proxies a OnStartRequest to us. This lets us know that the connection has been established.
Assignee | ||
Comment 9•23 years ago
|
||
This is caused by my patch to dumb down SSL connections if the handshake fails after a connect when SSL v3.1 is enabled. Some thread blocks on a read because I left the socket in blocking mode after a connect. I'm working on a patch to not leave the socket in blocking mode after a connect.
Assignee: ddrinan → javi
Reporter | ||
Comment 10•23 years ago
|
||
good catch Javi! I was just about to say that it looks like the regression happended the same day 64888 was fixed (June 7th). Let me know if you still need me to call you to work this out. I can also test any patches you've got for us.
Assignee | ||
Comment 11•23 years ago
|
||
Assignee | ||
Comment 12•23 years ago
|
||
mscott: The patch worked for me. Could you guys beat on it a little more to make sure it works for you guys as well. Thanks.
Reporter | ||
Comment 13•23 years ago
|
||
it works like a champ for me!
Assignee | ||
Comment 14•23 years ago
|
||
Assignee | ||
Comment 15•23 years ago
|
||
wtc, please review my latest patch. Thanks.
Comment 16•23 years ago
|
||
r=wtc@netscape.com.
Reporter | ||
Comment 17•23 years ago
|
||
*** Bug 85584 has been marked as a duplicate of this bug. ***
Comment 18•23 years ago
|
||
*** Bug 85598 has been marked as a duplicate of this bug. ***
Comment 19•23 years ago
|
||
sr=blizzard
Reporter | ||
Comment 20•23 years ago
|
||
*** Bug 85618 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 21•23 years ago
|
||
*** Bug 85607 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 22•23 years ago
|
||
*** Bug 82970 has been marked as a duplicate of this bug. ***
Comment 23•23 years ago
|
||
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Blocks: 83989
Assignee | ||
Comment 24•23 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 25•23 years ago
|
||
*** Bug 85816 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 26•23 years ago
|
||
*** Bug 85892 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 28•23 years ago
|
||
*** Bug 85970 has been marked as a duplicate of this bug. ***
Comment 29•23 years ago
|
||
Fixed for me on Win 98 - you guys are good!
Comment 30•23 years ago
|
||
*** Bug 86648 has been marked as a duplicate of this bug. ***
Comment 31•23 years ago
|
||
*** Bug 85338 has been marked as a duplicate of this bug. ***
Comment 32•23 years ago
|
||
*** Bug 86675 has been marked as a duplicate of this bug. ***
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•