853475 - Remove unused nsICapturePicker code from /layout/forms

Status: RESOLVED DUPLICATE of bug 838354

(Core :: Layout: Form Controls, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

nsICapturePicker (see bug 567323 for details) is no longer implemented anywhere.  It was originally used in XUL Fennec; we removed the last copies of that code in bug 831236, bug 730289, and bug 795630.

This patch removes the layout code that attempts to use nsICapturePicker.

I couldn't find a string for the "capture" button label -- am I correct in thinking it was never localized?

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

I forgot to remove layout_forms.xpt from the package-manifest files.

Comment 2

[Matt Brubeck (:mbrubeck)]

Pushed to Try: https://tbpl.mozilla.org/?tree=Try&rev=c829816ed792

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 727842 [details] [diff] [review]
patch v2

Adding Jim just for the Metro changes -- just a few lines of CSS we missed in bug 795630.

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 727842 [details] [diff] [review]
patch v2

my bad, I didn't think to look for css when I removed the main parts.

Comment 5

[Mounir Lamouri (:mounir)]

Sorry Matt, bug 838354 is doing exactly that. It's part of a patch queue that is blocked by a review. Let me know if you need this to land ASAP, I think I could land that patch separately but hopefully the blocker should be resolved soon.

Comment 6

[Matt Brubeck (:mbrubeck)]

No hurry; I was just doing this for cleanup.  I'll land just the Metro part for now.