853541 - Revert load() to be cwd-relative, add loadRelativeToScript()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Bug 835552 broke sunspider, and doesn't match other JS shells. This bug will revert the load() part, but still add ways to do things script-relative.

Comment 1

[Nicholas Nethercote [inactive]]

Vindication! :P

Comment 2

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/028b8d687387

Comment 3

[Nicholas Nethercote [inactive]]

Hmm:

  Bug 853541 - Partially revert bug 835552, making load() be cwd-relative again. r=njn 

What you landed looks fine, but I probably would have asked for review on a patch like this.  No biggie.

Comment 4

[Steve Fink [:sfink] [:s:]]

err... oops, my faulty memory said that I already did that. From you, even. When in fact, it looks like I never even uploaded a patch here.

Uh... would you mind doing a post-facto review? This really should have a review, and I'm not at all sure it'll pass without comments. I'm tempted to back it out, in fact, but OTOH I don't want to introduc yet more churn.

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Partially revert bug 835552, making load() be cwd-relative again.

This patch also fixes an ASan error where I was strcpy'ing an address to itself.

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 729244 [details] [diff] [review]
Partially revert bug 835552, making load() be cwd-relative again.

Review of attachment 729244 [details] [diff] [review]:
-----------------------------------------------------------------

Honest mistake;  don't bother backing it out.

::: js/src/shell/js.cpp
@@ +843,5 @@
> +    return LoadScript(cx, argc, vp, false);
> +}
> +
> +static JSBool
> +LoadScriptRelativeToScript(JSContext *cx, unsigned argc, jsval *vp)

Nit: I'd call this LoadRelativeToScript, to match loadRelativeToScript.

Comment 7

[Steve Fink [:sfink] [:s:]]

Landed long ago as 028b8d687387