853625 - WikiMO: Error: Call to a member function getPrefixedText() on a non-object on Special:ProtectedPages

Status: VERIFIED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://wiki.mozilla.org/Special:ProtectedPages throws a 500:

Error: Call to a member function getPrefixedText() on a non-object

Sample stack trace

…at /data/www/wiki.mozilla.org/wiki/includes/specials/SpecialProtectedpages.php (135)
…at /data/www/wiki.mozilla.org/wiki/includes/specials/SpecialProtectedpages.php (320)
…sPager::formatRow called at /data/www/wiki.mozilla.org/wiki/includes/Pager.php (353)
…at /data/www/wiki.mozilla.org/wiki/includes/specials/SpecialProtectedpages.php (63)
…cute called at /data/www/wiki.mozilla.org/wiki/includes/SpecialPageFactory.php (476)
…ctory::executePath called at /data/www/wiki.mozilla.org/wiki/includes/Wiki.php (263)
…ki::performRequest called at /data/www/wiki.mozilla.org/wiki/includes/Wiki.php (593)
in MediaWiki::main called at /data/www/wiki.mozilla.org/wiki/includes/Wiki.php (503)
in MediaWiki::run called at /data/www/wiki.mozilla.org/wiki/index.php (58)

Comment 1

[Jason Crowe [:jd]]

that page loads for me, do you have any further details? like what skin you are using or if you are logged in or not etc...

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Jason Crowe [:jd] from comment #1)
> that page loads for me, do you have any further details? like what skin you
> are using or if you are logged in or not etc...

Logged in, GMO theme set.

Comment 4

[Jason Crowe [:jd]]

While I cannot reproduce this on prod I am able to reproduce it consistently on dev I have some additional error logging enabled there but it sheds no light on the subject.

Hopefully hexmode has some ideas. If not then we will probably need to file a bug upstream to work towards a resolution.

Comment 5

[Mark A. Hershberger (hexmode)]

I see the white page no matter what the skin I use.  Looking at the source.

Comment 6

[Mark A. Hershberger (hexmode)]

Attachment: patch for debugging

Could someone apply this patch, reproduce the error, and then tell me what the error log shows?

Comment 7

[Mark A. Hershberger (hexmode)]

Also, it would be helpful to know if update.php was run after upgrading the wiki.  If it was, that would mean the db schema has been updated.

Comment 8

[Jason Crowe [:jd]]

Attachment: Debug Output

Hex,

I manually applied the patch to dev and hit the page, debug output attached.

Comment 9

[Mark A. Hershberger (hexmode)]

So, for some reason there is a row in the list of protected pages in the MozillaWiki namespace without a title that is protected.  Since we can see the length of the page (1130), we can see the list before and after that page with the following links:

https://wiki.mozilla.org/Special:ProtectedPages?namespace=4&sizetype=max&size=1129
https://wiki.mozilla.org/Special:ProtectedPages?namespace=4&sizetype=min&size=1131

I'm not sure how this page would have gotten in there but maybe if we find the page, we can get a better idea of what happened.

Running the following query should produce the page:

 select page_id, page_title from  page, page_restrictions where page_id=pr_page and
 page_namespace=4 and page_len=1130

Comment 10

[Mark A. Hershberger (hexmode)]

Patch to fix this: https://gerrit.wikimedia.org/r/#/c/55491/

Comment 11

[Mark A. Hershberger (hexmode)]

Maybe someone can run the cleanupTitles.php maintenance script on that wiki to
fix the broken rows?

Comment 12

[Mark A. Hershberger (hexmode)]

Better fix: https://gerrit.wikimedia.org/r/#/c/56125/

If I knew were to apply that patch, I would.

Comment 13

[Jason Crowe [:jd]]

I ran the cleanupTitles.php maintenance script and the issue has gone away.

Hex, do I need to apply this patch or is it safe to wait till the next point release to just get it at that time?

Comment 14

[Mark A. Hershberger (hexmode)]

you can wait on that.  cleanupTitles is enough.

Comment 15

[Jason Crowe [:jd]]

Thank you, I will close this out then.
Cheers

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks good to me, thanks -- verified FIXED.