853725 - B2G MMS: fail to read nsIDOMMozMmsMessage.receivers for a received MMS (a follow-up of bug 849741)

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gene Lian (I already quit Mozilla)]

This is a follow-up fix for bug 852911. Without this, the Gaia end would crash when trying to read |.receivers| for a received MMS. I believe this one should be a critical issue so leo+. Please let me know if anyone doesn't agree on this or ping me for more details. Thanks!

Comment 1

[Gene Lian (I already quit Mozilla)]

(In reply to Gene Lian [:gene] from comment #0)
> This is a follow-up fix for bug 852911.
                              ^^^^^^^^^^ Sorry, it should be bug 849741.

Comment 2

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

This patch prevents us from falling into the following check at [1]:

NS_IMETHODIMP
MmsMessage::GetReceivers(JSContext* aCx, JS::Value* aReceivers)
{
  uint32_t length = mReceivers.Length();
  if (length == 0) {
    return NS_ERROR_UNEXPECTED;
  }
  // skip...
}

[1] http://mxr.mozilla.org/mozilla-central/source/dom/mobilemessage/src/MmsMessage.cpp#307

Comment 3

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V1.1

Fix a nit. Please see comment #2. Thanks!

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 728043 [details] [diff] [review]
Patch, V1.1

Review of attachment 728043 [details] [diff] [review]:
-----------------------------------------------------------------

There are still problems in handling incomplete receivers in notification indication PDUs. Let's open another follow-up bug and don't block Gaia developers for now.

Comment 5

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/52ae75e1909c

Comment 6

[Gene Lian (I already quit Mozilla)]

Nominate for leo+ because this one is a follow-up for bug 849741.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/52ae75e1909c

Comment 8

[Gene Lian (I already quit Mozilla)]

We'll use b2g18-approval to uplift this after nominating for it.

Comment 9

[Gene Lian (I already quit Mozilla)]

Comment on attachment 728043 [details] [diff] [review]
Patch, V1.1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 849741
User impact if declined: without this, the Gaia end would crash to read the MMS' receivers info because we don't allow an MMS to contain no receivers. To solve this, we have to add an alternative receiver name at least even if we cannot get a valid phone number from ICC.
Testing completed: yes
Risk to taking this patch (and alternatives if risky): please don't hesitate to land this because it's just a follow-up for bug 849741 and only touches the MMS internal codes. I believe we don't have any risk to land this.
String or UUID changes made by this patch: no

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 728043 [details] [diff] [review]
Patch, V1.1

Low risk forward fix that is self-contained in module - go ahead with uplift.

Comment 11

[Gene Lian (I already quit Mozilla)]

Attachment: [b2g18] Patch

Comment 12

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/6759b57a7802

Comment 13

[Gene Lian (I already quit Mozilla)]

Added [NO_UPLIFT] per recent commercial RIL compatibility issue. Waiting on further decision to keep the patch in b2g18 or to back it out.

------------------------------
If we really want to back them out, backing the following MMS bugs should be enough to make the commercial RIL compatible:

Bug 854422 - B2G MMS: should call .NotifyResponseTransaction() with MMS_PDU_STATUS_RETRIEVED after an MMS is retrieved under the RETRIEVAL_MODE_AUTOMATIC mode (a follow-up for bug 845643)
Bug 850680 - B2G MMS: broadcast "sms-received" and "sms-sent" system messages
Bug 850530 - B2G MMS: Use the same attribute name for delivery (s/state/delivery) like SMS
Bug 852911 - B2G MMS: fail to expose correct nsIDOMMozMmsMessage.attachments.
Bug 853725 - B2G MMS: fail to read nsIDOMMozMmsMessage.receivers for a received MMS (a follow-up of bug 849741).
Bug 853329 - B2G MMS: other Android phones cannot read attachments sent from FFOS
Bug 852471 - B2G MMS: provide nsIDOMMobileMessageManager interface (with sendMMS() first) (follow-up fix)
Bug 852460 - B2G MMS: provide nsIDOMMobileMessageManager.onreceived event (follow-up fix)
Bug 849741 - B2G MMS: provide nsIDOMMobileMessageManager.onreceived event
Bug 847756 - B2G MMS: provide nsIDOMMobileMessageManager.markMessageRead().
Bug 847736 - B2G MMS: provide nsIDOMMobileMessageManager.delete().
Bug 847738 - B2G MMS: provide nsIDOMMobileMessageManager.getMessage(). 
Bug 844431 - B2G MMS: provide nsIDOMMobileMessageManager interface (with sendMMS() first)
Bug 845643 - B2G MMS: Save retrieved MMS into database.

Comment 14

[Gene Lian (I already quit Mozilla)]

Following the previous comment, some more needs to back out:

Bug 792321 - Check max values of MMS parameters in sendRequest.
Bug 833291 - B2G SMS & MMS: getMessages it's not working with PhoneNumberJS
Bug 844429 - B2G SMS & MMS: move SMS codes into dom/mobilemessage to make it generic for MMS
Bug 839436 - B2G MMS: make DB be able to save MMS messages.

Comment 15

[Gene Lian (I already quit Mozilla)]

Confirming with Michael to see we should back out to Bug 839436 or just Bug 844431 (if we eventually decide to back out). Please see Bug 857632, comment #17.

Comment 16

[Gene Lian (I already quit Mozilla)]

Per off-line discussion with Michael, we decided not to back out the MMS bugs that have already been in mozilla-b2g18. Removing [NO_UPLIFT] to make the check-in status sync'ed.