853756 - [Buri][WIFI]The icon display wrong after connected to AP

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[sync-1]

+++ This bug was initially created as a clone of Bug #424482 +++
 
 DEFECT DESCRIPTION:
 The icon display wrong after connected to AP
 REPRODUCING PROCEDURES:
 1.turn on Wi-Fi,and connect to AP
 2.In the process of connecting to AP,the icon flow,but after connect to AP successfully,sometimes the icon also flow,sometimes the icon is normally->KO
 EXPECTED BEHAVIOUR:
 the icon should display normally when connect to AP successfully
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 
 REPRODUCING RATE:2/5
 
 For FT PR, Please list reference mobile's behavior:
 
 AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.19.037
 Firefox os  v1.0.1
 Mozilla build ID: 20130310070203.
 
 ++++++++++ end of initial bug #424482 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
 DEFECT DESCRIPTION:
 
 REPRODUCING PROCEDURES:
 
 EXPECTED BEHAVIOUR:
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 
 REPRODUCING RATE:
 
 For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Created an attachment (id=375709)
 pics

Comment 2

[sync-1]

Attachment: pics

Created an attachment (id=375709)
 pics

Comment 3

[sync-1]

Created an attachment (id=375711)
 pics

Comment 4

[sync-1]

Attachment: pics

Created an attachment (id=375711)
 pics

Comment 5

[xiupinglong]

hi,

This issue is caused by  wifi 'icon.dataset.connecting'. When wifi status is
'connected', but signal level = 0, and now 'icon.dataset.connecting = true'.
This situation equals the CSS which show connecting icon other than level = 0 icon . 

Just add 'delete icon.dataset.connecting' if 'icon.dataset.connecting == true' in connected code.

Comment 6

[xiupinglong]

Attachment: patch for wifi icon display wrong

Comment 7

[xiupinglong]

But,some other issue should be solved too. That is why the connected wifi's
signal level equals 0. 

It seems that the wifi signalStrength has a mistake.
This issue always reproduce when restart the phone.

As I found the log follow:
The system app (statusbar) LOG:
I/Gecko   (  144): getConnectionInformation info.signalStrength = -96
I/Gecko   (  144): getConnectionInformation info.relSignalStrength = 8
E/GeckoConsole(  144): Content JS LOG at
app://system.gaiamobile.org/js/statusbar.js:499 in sb_updateWifi: 
relSignalStrength = 8
E/GeckoConsole(  144): Content JS LOG at
app://system.gaiamobile.org/js/statusbar.js:500 in sb_updateWifi: 
icon.dataset.level = 0

While the settings app LOG:
I/Gecko   (  145):  onscanresultsavailable network.ssid = Connectify-me
=== Number(match[3])[注：signalStrength] = -57 === signal = 95
I/Gecko   (  145): lxp:: onscanresultsavailable network.relSignalStrength = 95
E/GeckoConsole(  400): Content JS LOG at
app://settings.gaiamobile.org/js/wifi.js:333 in onScanSuccess: 
network.ssid = Connectify-me ===settings network.relSignalStrength = 95

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 736654 [details] [diff] [review]
patch for wifi icon display wrong

Review of attachment 736654 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the lint issue fixed

::: apps/system/js/statusbar.js
@@ +491,4 @@
>          case 'connected':
>            icon.hidden = false;
>  
> +          if(icon.dataset.connecting) {

nit: missing a space before the |(|, this won't pass the linter.

Comment 9

[xiupinglong]

Attachment: patch for bug853756

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 736736 [details] [diff] [review]
patch for bug853756

Review of attachment 736736 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 11

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/bc54b1482e32245ec5d8ff1316c77b6c1d968dc6

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 853756 to:
v1-train: 3d3de3a9c12e48190a3e1f3c59a4e97f90678234
v1.0.1: 37b659535f9e8345e1a2adfc2d5871889ae66355

Comment 13

[rafael.marquez]

Tested with:
Gecko: ea6a890
Gaia: b750757
QC RIL: V1.01.00.01.19.072