853777 - CodeGenerator.cpp:1542:16: warning: unused variable ‘cx’ [-Wunused-variable]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

New build warning (encountered in my m-i build today, though I think it affects m-c too now):

{
/mozilla/js/src/ion/CodeGenerator.cpp: In member function ‘virtual bool js::ion::CodeGenerator::visitApplyArgsGeneric(js::ion::LApplyArgsGeneric*)’:

/mozilla/js/src/ion/CodeGenerator.cpp:1542:16: warning: unused variable ‘cx’ [-Wunused-variable]
}

Link to MXR: 
https://mxr.mozilla.org/mozilla-central/source/js/src/ion/CodeGenerator.cpp#1542

The variable is indeed unused -- it was orphaned by bug 849388, which removed the last usage of it, here:
https://hg.mozilla.org/mozilla-central/rev/2b9b303c9161#l2.40

The variable presumably can just be dropped.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

This fixes it.

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 728103 [details] [diff] [review]
fix

Review of attachment 728103 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking care of this.  Sorry for introducing the warning.

Comment 3

[Daniel Holbert [:dholbert]]

No problem - thanks for the quick review turnaround.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a614c0fa8f76

Comment 4

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/a614c0fa8f76