854175 - permanent PB mode adds "(Private Browsing)" to window title

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Christian Ascheberg]

There is a "(Private Browsing)" suffix in the window title if permanent private browsing mode is activated. The suffix should not be shown in that case.

Comment 1

[Christian Ascheberg]

Attachment: patch

This is a possible patch

Comment 2

[(no longer active)]

Comment on attachment 728709 [details] [diff] [review]
patch

Review of attachment 728709 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks good!

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e6b20451bb6

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Why we want this behavior? It is now harder to know whether you're in PB mode, isn't it?

Comment 5

[(no longer active)]

(In reply to comment #4)
> Why we want this behavior? It is now harder to know whether you're in PB mode,
> isn't it?

We don't want to keep reminding you that you are in *permanent* PB mode all the time.  We want Firefox in that mode to look similar to regular mode but just don't store any local data about your browsing.  We still set the window title for normal PB mode.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #5)
> We don't want to keep reminding you that you are in *permanent* PB mode all
> the time.
Why not?

Comment 7

[(no longer active)]

(In reply to comment #6)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #5)
> > We don't want to keep reminding you that you are in *permanent* PB mode all
> > the time.
> Why not?

Because it is an explicit choice that you make in the Preferences dialog.  We don't keep reminding you that you have changed other settings there all the time either.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4e6b20451bb6

Comment 9

[Christian Ascheberg]

Is it worth it to uplift this patch to beta?

Comment 11

[(no longer active)]

Yeah please nominate it for both Aurora and Beta.

Comment 12

[Christian Ascheberg]

Comment on attachment 728709 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (feature/regressing bug #): bug 799001 / per-window private browsing
User impact if declined: unwanted "(Private Browsing)" suffix in the window title during permanent private browsing mode
Testing completed (on m-c, etc.): m-c, aurora 22.0a2
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/132b6ad632cc

Comment 14

[u279076]

Ioana, can you please make sure this gets verified in the latest Aurora build and the upcoming Firefox 21b3 build? Thanks

Comment 15

[Ioana (away)]

Verified as fixed on Windows 7 64bit - the 04/10 Aurora and Nightly, and on Ubuntu 12.10 32bit - the 04/11 Aurora and Nightly.

The PB string is no longer displayed in the title bar when passing in permanent PB mode, nor when opening new windows while still in this mode.

Comment 16

[Ioana (away)]

Verified as fixed on Windows 7 64bit, Ubuntu 12.10 32bit and Mac OSX 10.7.5 with Firefox 21 beta 3 (20130416200523).