854212 - Build error with jsfuninlines.h:194: undefined reference to `JSFunction::ExtendedFinalizeKind' / jsfuninlines.h:194: undefined reference to `JSFunction::FinalizeKind'

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

This morning, my local mozilla-central debug build fails to compile, with this error:
 1:04.77 
 1:04.77 ../libjs_static.a(jsinterp.o): In function `js::CloneFunctionObjectIfNotSingleton(JSContext*, JS::Handle<JSFunction*>, JS::Handle<JSObject*>)':
 1:04.77 /mozilla/js/src/jsfuninlines.h:194: undefined reference to `JSFunction::ExtendedFinalizeKind'
 1:04.77 /mozilla/js/src/jsfuninlines.h:194: undefined reference to `JSFunction::FinalizeKind'
 1:04.77 /usr/bin/ld.bfd.real: js: hidden symbol `_ZN10JSFunction12FinalizeKindE' isn't defined
 1:04.77 /usr/bin/ld.bfd.real: final link failed: Bad value
 1:04.77 collect2: error: ld returned 1 exit status

Comment 1

[Daniel Holbert [:dholbert]]

This was a clobber build, on 64-bit Ubuntu Linux with GCC 4.7.2.

Comment 2

[Daniel Holbert [:dholbert]]

hg bisect says the first bad revision is:

changeset:   126040:82ea4e6d7349
user:        Luke Wagner <[e-mail]>
date:        Sat Mar 23 05:31:01 2013 -0700
summary:     Bug 851421 (part 1) - Clone extended function slots.  r=nnethercote.

which makes sense, because that's what added the references to ExtendFinalizeKind/FinalizeKind in jsfuninlines.h (in the last chunk of the cset):
 https://hg.mozilla.org/mozilla-central/rev/82ea4e6d7349#l3.2

Comment 3

[Daniel Holbert [:dholbert]]

I suspect that what I'm hitting is "the opposite link error on linux" that Luke referred to in bug 851421 comment 21. (context: it's the opposite of another linking error that was hit on Try at one point, for these symbols being already defined)

Comment 4

[Daniel Holbert [:dholbert]]

My mozconfig looks like:
{
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../obj
ac_add_options --enable-debug --disable-optimize

mk_add_options MOZ_MAKE_FLAGS='-s -j8'
ac_add_options --with-ccache=/usr/bin/ccache

# Don't want installer/updater in my local builds
ac_add_options --disable-installer
ac_add_options --disable-updater

ac_add_options --enable-valgrind
ac_add_options --enable-warnings-as-errors
}

Comment 5

[Daniel Holbert [:dholbert]]

(I'm hitting this in up-to-date mozilla-inbound, too, so it looks like this hasn't been fixed elsewhere yet.)

Comment 6

[Luis de Bethencourt [:luisbg]]

This build error happens with the --enable-debug flag.

A non-debug build doesn't fail.

Comment 7

[Luis de Bethencourt [:luisbg]]

static const js::gc::AllocKind FinalizeKind
static const js::gc::AllocKind ExtendedFinalizeKind

are defined in jsfun.h:251

Not sure why they aren't being included in debug build, but are in the default one.

Comment 8

[Nicholas Nethercote [inactive]]

Attachment: Fix link errors in jsfuninlines.h caused by bug 851421.

I can reproduce this with gcc-4.7 on my Linux box.  (I normally use clang-3.2.)

This is mostly explained by
http://stackoverflow.com/questions/4891067/weird-undefined-symbols-of-static-constants-inside-a-struct-class.

Basically, if a |static const| class member is used in a non-const expression,
on Linux (GCC, and sometimes clang) you need to also define it outside of the
class.  But on Windows defining it outside the class causes it to be defined
multiple times!  The solution, which this patch does, is to assign the constant
to a temporary variable so it's only used in const expressions.  I hit the same
problem in bug 747831 -- see the comment in
TokenStream::SourceCoords::SourceCoords in js/src/TokenStream.cpp.

I'll take r+ from whoever can first confirm this fix.  Thanks!

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 728783 [details] [diff] [review]
Fix link errors in jsfuninlines.h caused by bug 851421.

This let's me to build m-c

Comment 10

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/683bb0caab3a

Comment 11

[Luis de Bethencourt [:luisbg]]

It works for me as well. Thanks! :)

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Have to get m-c working too, so landed there
https://hg.mozilla.org/mozilla-central/rev/631d57b31bb1

Comment 13

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/683bb0caab3a