854301 - [Marketplace] Error shown when you try to submit a review

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[Walter Chen[:ypwalter][:wachen]]

unagi, v1train pvt pub 20130324 build.
build identifier 20130324070203

STR:
  1. open "Marketplace" app
  2. choose any app
  3. choose "submite your review" or "edit your review"
  4. select stars and comment on the textarea

expect result:
  When clicking "cancel", it should go back to app download/launch screen
  When clicking "submit review", it should submit review
actual result:
  When clicking "cancel", it didn't work at all
  When clicking "submit review", it showed that "A server error has occurred". Furthermore, if you go back to app selection screen and come back to app download/launch screen, you would see that the comment has been made.

Comment 1

[Jason Smith [:jsmith]]

FYI - For anything marketplace-related, it belongs in the Marketplace product. They track things differently for the most part, so no need to nom on those bugs if they go in that product.

Comment 2

[Walter Chen[:ypwalter][:wachen]]

Jason, thanks for helping. I really don't know that before.

Comment 3

[[e-mail]]

Fix for the cancel button part of this is up for review here: https://github.com/mozilla/zamboni/pull/691

Oddly I'm not seeing the submission error in -dev - it only seems to happen in prod. Not sure if this means there's already a fix that's not been deployed.

Comment 4

[[e-mail]]

Cancel noop fix is landed https://github.com/mozilla/zamboni/commit/41590d12a44ecca3ea68a84ba1b5fb3e1b1b5959

Comment 5

[Walter Chen[:ypwalter][:wachen]]

Woops, only happening in production is not good...
So, this issue is still needed to be tracked while "A server error has occurred" is in production marketplace.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Reviews have been broken in production since Thursday. That's really unfortunate. Thanks for reporting this, Walter - much appreciated.

Fixed on -dev: https://github.com/mozilla/zamboni/commit/db83b6e

Also: thank you, Stuart, for fixing the cancel button.

Comment 7

[Walter Chen[:ypwalter][:wachen]]

Chris, thanks you.
As long as this got fixed, I can finish my automation.
I will verify this once this is in.

Just quick questions about marketplace. 

Should I concern about which branch the code would go?
If so, can you uplift the code to v1train/v101(shira)?
If not, can you explain a little bit more about the procedure/flow of marketplace code? I'd like to understand more so that I might be able to help more next time!

Comment 8

[Walter Chen[:ypwalter][:wachen]]

I saw none of this 2 things got fixed in marketplace as for today.
Please provide feedback.
And, I think since the review have bben broken, that means not fixed for this issue.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

(In reply to Walter Chen from comment #8)
> I saw none of this 2 things got fixed in marketplace as for today.
> Please provide feedback.
> And, I think since the review have bben broken, that means not fixed for
> this issue.

We push to production on Thursdays at 2:00 PDT. Check back tomorrow - thanks.

You can see it fixed on our staging/development server at https://marketplace-dev.allizom.org/telefonica/ until then. We mark fixed bugs as RESOLVED FIXED.

Comment 10

[Christopher Van Wiemeersch [:cvan]]

Walter, also FWIW, submitting a review does actually make a POST to the server. We just fail on the redirect after the review is posted, which means you get that ugly error message and you cannot see your own review (until you refresh the page on desktop -or- restart the app on mobile). Everyone else can, however, see your review. This was a bad bug, yes. But it does not block users from reviewing apps. Anyway, check back tomorrow for the fix in production - thanks!

Comment 11

[Victor Carciu]

Verified as fixed on Unagi. Both Cancel and Submit buttons are working as expected.