854383 - doing "make purge" twice fails

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* make purge
* make purge

Expected:
* no error

Actual:
* we have an error :

  $ make purge
  adb shell stop b2g
  make: *** [purge] Erreur 1

This is especially problematic when doing |make reset-gaia| because |purge| is a dependency.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: patch v1

This inverts the check for the tmp directory so that it is true instead of
false.

Also removes the silent modifier for this line, there is no reason to silent
this line.
---
 Makefile |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 728946 [details] [diff] [review]
patch v1

Review of attachment 728946 [details] [diff] [review]:
-----------------------------------------------------------------

::: Makefile
@@ +729,2 @@
>  	do \
> +		[ $$FILE = 'tmp' ] || $(ADB) shell rm -r $(MSYS_FIX)/data/local/$$FILE; \

That changes

Comment 3

[Julien Wajsberg [:julienw]]

(In reply to Fabrice Desré [:fabrice] from comment #2)
> 
> Review of attachment 728946 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: Makefile
> @@ +729,2 @@
> >  	do \
> > +		[ $$FILE = 'tmp' ] || $(ADB) shell rm -r $(MSYS_FIX)/data/local/$$FILE; \
> 
> That changes

mmm yes ?

Comment 4

[[:fabrice] Fabrice Desré]

This is what you get when you start a review before 2 hours of triage and finish it after.

Comment 5

[Julien Wajsberg [:julienw]]

master: 819e1621b5a8fb6175e4551e8ae14a5c2dd48629
v1-train: dcc5bc0c11de0f9633b9fc0bf48408d2791efdc7 (a=npotb)
v1.0.1: 4db5ee1208ae05dbc7c478109d90d5da6a345f41 (a=npotb)