854881 - Change - Remove Master Password Support

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P1)

Description

[Jim Mathies [:jimm]]

See bug 853391. We will not support this feature in metrofx.

Comment 1

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

I kept browser\metro\base\content\preferences.js because it's used by the patch for bug 845484. Once that one lands I can update this patch.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 729901 [details] [diff] [review]
Patch v1

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c4bad14048d

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c4bad14048d

Comment 4

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130404 Firefox/23.0

No Master Password in Options. Visiting and logging in to a site which requires authentication saved the password without problems.

Comment 5

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #6 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/

- Ensured that "Master Password" is not present under "Options" in the "Setting" charm
- Ensured that a "Remember Password" prompt appears at the top of the browser when logging into a website with a password
- Ensured that selecting "Remember Password" saves the passwords and can be used to re-login without issues (tried several different sites)
- Ensured that you can "Change" the password if you inserted an incorrect password previously
- Ensured that selecting "Clear" under "Options" removes all of the saved passwords

Comment 6

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Change" for iteration #8 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-14-03-11-00-mozilla-central/

- Went through the test cases added in comment 5 without any issues
- Ensured that selecting "Not for this site" will not ask the user to remember the password again for that particular site
- Ensured that the "Remember Password" is not dismissed until a user makes a selection

Found Bug 883484 when going through the following "Change" but found a better "Story" to block.

Comment 7

[Asa Dotzler [:asa]]

This does not have a story to attach to since it's a removal of a feature that was never captured in a Metro story.

Comment 8

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment5 and 6 got expected result.

Comment 9

[aasymonds]

FWIW in the current Metro build, when I forced a sync with my account which has a master account set up IN ADDITION to other security measures I have in place and all my passwords were brought in but no master password is ever needed within Metro.

I think it's a really bad idea to not allow a user to encrypt passwords at the Metro Firefox level via the existing sync system especially considering the recent press regarding Chrome's lack of a master password issue.

Comment 10

[Asa Dotzler [:asa]]

(In reply to aasymonds from comment #9)
> FWIW in the current Metro build, when I forced a sync with my account which
> has a master account set up IN ADDITION to other security measures I have in
> place and all my passwords were brought in but no master password is ever
> needed within Metro.
> 
> I think it's a really bad idea to not allow a user to encrypt passwords at
> the Metro Firefox level via the existing sync system especially considering
> the recent press regarding Chrome's lack of a master password issue.

Thank you for your input, aasymonds. For future reference, advocacy comments are not appropriate for Bugzilla.  You can learn more about how we use Bugzilla here https://bugzilla.mozilla.org/page.cgi?id=etiquette.html