854948 - GCLI context.environment.contentDocument points to doc from when GCLI first opened

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Since recent GCLI changes context.environment.contentDocument always points to the content document from when GCLI was first opened.

It should obviously point to the current content document.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

context.environment.contentDocument.location.href = the correct content document URI.
context.environment.contentDocument.body.innerHTML = HTML from the page when GCLI was first loaded.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Seems like the debugger gave me bad information. Seems like context.environment.contentDocument.location is null :o/

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

console.log(context.environment.contentDocument) gives HTMLDocument {"location":null}

Comment 4

[Joe Walker [:jwalker]]

Attachment: v1

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 740005 [details] [diff] [review]
v1

Review of attachment 740005 [details] [diff] [review]:
-----------------------------------------------------------------

That simple? Looks good to me, r+.

Comment 6

[Joe Walker [:jwalker]]

Could you double check that this solves your appcache problem please?

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Joe Walker [:jwalker] from comment #6)
> Could you double check that this solves your appcache problem please?

I already had, it works just fine.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/9a35bbea86c7

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/9a35bbea86c7