855043 - Space/text display issues of the new download buttons (el locale)

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect, P3)

Description

[George Fiotakis]

As usually, Greek text needs more space.
So far we have a problem only with the small "firefox beta for android" button.
As a workaround, I translated the string "Get it free on Google Play" as "Free on Google Play" since it still makes perfectly good sense in Greek and added a <br/> to break it in two lines.

Filling this bug since I'm not sure if the <br/> breaks something or if the workaround is also working for Firefox Aurora buttons

Comment 1

[Jennifer Bertsch [:jbertsch]]

added to mozilla.org kanban board

Comment 2

[Steven Garrity [:sgarrity]]

I wondered if a non-breaking space to keep "Google Play" together might be a better option that embedding HTML in the string?

Alternately, we could adjust the margin-right values in the CSS for Greek-only.

Comment 3

[Alex Gibson [:agibson]]

As a note - we currently have a CSS rule to fix this same issue (i think) for dutch visitors, so it might just be a case of adding 'el' to this existing selector.

https://github.com/mozilla/bedrock/blob/master/media/css/sandstone/buttons.less#L580

Comment 4

[Alex Gibson [:agibson]]

PR opened here:

https://github.com/mozilla/bedrock/pull/1087

This should remove the need for using the <br /> breaks, as the width of the text container is adjusted so it no longer overlaps the Firefox Beta text.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a429611e3e73c4b8c1154714f75ec3888266d78b
Bug 855043 text display issues download buttons (el locale)

https://github.com/mozilla/bedrock/commit/41559624a9c9fb086c3d3356b60f5c3193686b41
Merge pull request #1087 from alexgibson/bug-855043-text-display-issues-download-buttons-el

Bug 855043 text display issues download buttons (el locale)

Comment 6

[raymond [:retornam] (inactive)]

fixed on stage 
https://www.allizom.org/el/styleguide/websites/sandstone/buttons/

Comment 7

[raymond [:retornam] (inactive)]

https://www.mozilla.org/el/styleguide/websites/sandstone/buttons/