Closed Bug 855078 Opened 11 years ago Closed 11 years ago

Move off libxpcom

Categories

(Other Applications Graveyard :: PyXPCOM, defect)

Product:
Other Applications Graveyard
Component:
PyXPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mark.yen, Unassigned)

References

Details

Attachments

(1 file)

patch
11.73 KB, patch
twhitema
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
Bug 852950 will kill libxpcom; we'll need to link against libxul instead.  Attached patch can get us to successful-looking `make check`.

This also includes nsCAutoString -> nsAutoCString changes and nsresult != unsigned long changes; basically, everything needed to build against ~ m-c from when libxpcom killing initially landed (before being backed out).
Attachment #729805 - Flags: review?(toddw)
Comment on attachment 729805 [details] [diff] [review]
patch

Please commit as two separate changes - one for libxul, the other for nsCAutoString -> nsAutoCString changes and nsresult != unsigned long changes.

Also, make sure we have proper pyxpcom version tags/branches before committing.
Attachment #729805 - Flags: review?(toddw) → review+
Todd went and checked in https://hg.mozilla.org/pyxpcom/rev/ba1f14b67538 and related changes.  I'm assuming that fixed things.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: