855084 - [B2G][Calendar] Swiping through Month View fast then rapidly switching to week view displays the day and date incorrectly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Jeni]

Attachment: Calender-week view

Description:
After navigating through month view quickly and switching to week view the UI displayed multiple days and dates.

Repro Steps:
1) Updated to Unagi Build ID: 20130322070203
2) Tap on Calender
3) Scroll through the calender months at a quick rate (8 or 9 months)
4) Tap on Week view
5) View what happens

Actual:
After swiping thru month view to several months and then clicking on week view the date and day are displayed twice.

Expected:
See that the day and date are listed one time in week view.

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4931ec89ebbe
Gaia: 85fd164691bb852f1cfaf82405df4380629ced6e

Also checked on Master 
Master build details
Unagi Build ID: 20130326031043
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/mozilla-central/rev/456cb08f8509
Gaia: d2a68bc3c26312bbd70c926aedbdef0fc972805e

Notes:
Repro frequency: 4/4, 75%,
See screenshot is attached.

This happens with or without calendar events.  Tested with google, yahoo, caldav accounts, by creating a long event span over a couple years, each were effected.  
Tested and affects both English and Spanish.

Comment 1

[Jeni]

Attachment: Logcat showing issue

Comment 2

[Jeni]

Attachment: Another picture showing issue

Comment 3

[Jason Smith [:jsmith]]

I can reproduce. This looks gross.

Edge case though, so doesn't block.

Comment 4

[Kevin Grandon :kgrandon]

Likely due to the way that the all-day events are constructed on the week view. I was actually working on another patch which should resolve this issue (it brings the all-day row into the week frame).

Comment 5

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 6

[James Lal [:lightsofapollo]]

Comment on attachment 731260 [details]
Github pull request pointer

Nice work!

In master: https://github.com/mozilla-b2g/gaia/commit/bdc26bc623b01d61d2f7748dcaa0d79650f1fd82

Comment 7

[James Lal [:lightsofapollo]]

Comment on attachment 731260 [details]
Github pull request pointer

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): See bug details.
User impact if declined: Edge case where week view UI is terribly ugly.
Testing completed: Manual testing / unit test minor updates to ensure functionality works.
Risk to taking this patch (and alternatives if risky): None that I can think of that will make this problem worse. I can no longer reproduce the bug with this fix.
String or UUID changes made by this patch:

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 bdc26bc623b01d61d2f7748dcaa0d79650f1fd82
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 9

[James Lal [:lightsofapollo]]

We can't do more here without conflicts resolved. Please supply a patch or uplift directly.

Comment 10

[Kevin Grandon :kgrandon]

Landed in v1-train: https://github.com/mozilla-b2g/gaia/commit/953d56bdb270dfa31c4cb903ac59830abac30f8e