855091 - Paris bindings for WheelEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=c88937e6a8bd

Comment 1

[Peter Van der Beken [:peterv]]

Comment on attachment 729824 [details] [diff] [review]
patch

Review of attachment 729824 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/DOMWheelEvent.cpp
@@ +123,5 @@
>    return NS_OK;
>  }
>  
> +static
> +void GetModifierList(bool aCtrl, bool aShift, bool aAlt, bool aMeta,

I think generaly we'd do:

static void
GetModifierList...

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49f0306ffa2f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/49f0306ffa2f