85543 - Extra blank box to the left of 'Done.' on mac classic skin.

Status: RESOLVED WORKSFORME

(SeaMonkey :: Themes, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID: 2001-06-12-08, Mac Classic 

There exists an extra small box the size of the offline indicator,
which is to the left of the Done. status.  

Note: On Mac Modern, there is a blank SPACE, but not a square.  Whatever code is
causing this same bug.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

downgrading to minor

Comment 2

[basic]

Changing platform

Comment 3

[timeless]

Attachment: begone

Comment 4

[Blake Ross]

r/sr=blake

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 48953 [details] [diff] [review]
begone

this rule is now empty and useless, just turn it into a comment; that removes the rule and helps resurrecting it just in case.

This bug is mac-classic specific and should be tested on a Mac.

r=glazman **providing the fact that it is visually tested on a Mac**.

Comment 6

[Keyser Sose]

r=ksosezoff to bed now.

Comment 7

[timeless]

fix checked into trunk, requesting branch approval this is an eyesore and 
verylow risk

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 48953 [details] [diff] [review]
begone

low risk medium reward. a=asa for checkin to the 0.9.4 branch

Comment 9

[timeless]

thanks

Comment 10

[timeless]

fix checked into trunk and branch

Comment 11

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

/me wonders what is the point asking for reviews if you don't follow
them and ask for other reviews when the existing one are not matching
your desire.

Why did you keep the empty ruleset in (that was in my review) ?

Comment 12

[andreww]

yes the rule should have been removed as well. This is a leftover from 
blake making a fix to windows classic skin and not (at the time) able to 
access mac classic.  The class selector should have been removed as 
well.

Comment 13

[Blake Ross]

I apologize for reviewing this hastily, I thought the entire rule was removed.

Comment 14

[timeless]

Attachment: trunk only; move whitespace (kill tabs, increase consistency) and whack the empty rule

Comment 15

[timeless]

Attachment: same patch, -u0w for reviewing (to show this doesn't do anything significant)

Comment 16

[timeless]

what's the point of complaining if you aren't going to listen to the response?

the patch itself needed to go in before 094 finalized, it did.  i've attached a 
cleanup patch which is designed for trunk only (since it benefits the branch so 
insignificantly it would only add risk, and therefor fail any sane risk/benefit 
analysis).

Comment 17

[Håkan Waara]

Changing the coding style in that file makes it inconsistent with the coding
style in all other files in that theme.

If you intend to make it consistent, please fix the unusual cases and not the
entire file.

that patch needs-work.

Comment 18

[Håkan Waara]

Ok, turns out some parts of mac-classic is written in one code style and some in
another.

Timeless, I suggest you just leave it alone (or create a new bug if you really
intend to "fix" it) - just make glazou's requested change (removing the unused
rule).

Comment 19

[[e-mail] (gone - use [e-mail] instead)]

Re-opening, until the final patch has been through the reviewal and checkin process.

Comment 20

[lchiang]

moved per 0.9.5 per pdt mtg.

Comment 21

[timeless]

.

Comment 22

[andreww]

the stuff that this patch would have fixed was already done in bug 97574.
Marking worksforme since it's already in .

Comment 23

[[e-mail] (gone - use [e-mail] instead)]

themes --> QA to pmac