856146 - event/core/off should prevent in-progress emits from calling the removed handler.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Dave Camp (:dcamp)]

In the dom:

--
function handler2() {
  console.log("got here");
} 
document.body.addEventListener("click", function() {
  document.body.removeEventListener("click", handler2);
});
document.body.addEventListener("click", handler2);
--

Will produce no output.  In addon-sdk:

--

function secondHandler() {
  console.log("got here");
}
 
on(target, "event", function() {
  off(target, "event", secondHandler);
});
on(target, "event", secondHandler);

--

Will print "got here".  This will cause some annoyance when converting devtools code from our EventEmitter to EventTarget, as we rely on off() in destroy methods to prevent further access to the object (and occasionally destroy objects from event handlers - usually in tests).

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/909

Pointer to Github pull-request

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/58aaa41444765afc5020638df04e91d0aecba8ce
Merge pull request #909 from Gozala/bug/remove-listeners@856146

fix Bug 856146 - Ignore removed listeners during dispatch. r=@ochameau

Comment 3

[[github robot]]

Commit pushed to integration at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/58aaa41444765afc5020638df04e91d0aecba8ce
Merge pull request #909 from Gozala/bug/remove-listeners@856146