Closed Bug 856170 Opened 11 years ago Closed 8 years ago

Reduce number of queries executed during FHR initialization

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: rnewman, Unassigned)

References

Details

Attachments

(1 file)

On a first run we execute 168 queries. I think we can do better than that.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Priority: -- → P2
Depends on: 833965
Attached patch Part 1. v1Splinter Review
This alone knocks 5% off our test execution times for services/metrics, and we don't even use IN (?…) to limit our fetch.
Attachment #731913 - Flags: review?(gps)
Comment on attachment 731913 [details] [diff] [review]
Part 1. v1

Review of attachment 731913 [details] [diff] [review]:
-----------------------------------------------------------------

Please re-request review once Sqlite.jsm API has been agreed upon. If the API doesn't change, I'll rubber stamp r+ (since there is nothing holding me back now except for API design questions).

::: services/metrics/storage.jsm
@@ +1191,5 @@
>        }
>  
>        // Don't perform DB transaction unless there is work to do.
> +      if (missingTypes.size) {
> +        let params = function params(array) {

Nit: I don't like names that conflict with built-ins, even if the case is different.
Attachment #731913 - Flags: review?(gps)
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Assignee: rnewman → nobody
FHR is going away per bug 1209088, wontfix.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: