Closed
Bug 856196
Opened 11 years ago
Closed 11 years ago
Fix compiler warnings and clean up code in NSPR 4.10
Categories
(NSPR :: NSPR, defect, P2)
NSPR
NSPR
Tracking
(Not tracked)
RESOLVED
FIXED
4.10
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
1.23 KB,
patch
|
KaiE
:
review+
wtc
:
checked-in+
|
Details | Diff | Splinter Review |
I will use this bug report for compiler warnings and minor issues that don't warrant their own bug reports. In the first patch, I pass NULL as the third argument to ReleaseSemaphore (this is allowed, see the lpPreviousCount in http://msdn.microsoft.com/en-us/library/windows/desktop/ms685071(v=vs.85).aspx ) and include "prlong.h" instead of "primpl.h", which contains a lot of unnecessary internal declarations.
Attachment #731323 -
Flags: review?(kaie)
|
||
Updated•11 years ago
|
Attachment #731323 -
Flags: review?(kaie) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
Comment on attachment 731323 [details] [diff] [review] Pass lpPreviousCount=NULL to ReleaseSemaphore. prlong.c only needs to include prlong.h. Review of attachment 731323 [details] [diff] [review]: ----------------------------------------------------------------- https://hg.mozilla.org/projects/nspr/rev/b211946d0f56 https://hg.mozilla.org/projects/nspr/rev/e2c212c02db7
Attachment #731323 -
Flags: checked-in+
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Priority: -- → P2
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•