856358 - Remove Contact types from window

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Reuben Morais [:reuben]]

As far as I can see, ContactProperties, ContactAddress, ContactField, ContactTelField, ContactFindSortOptions and ContactFindOptions are unnecessarily exposed to the Web.

Comment 1

[Reuben Morais [:reuben]]

Gregor, should those be exposed in |window|?

Comment 2

[Gregor Wagner [:gwagner]]

(In reply to Reuben Morais [:reuben] from comment #1)
> Gregor, should those be exposed in |window|?

They are basically just types for the API and dictionaries. Since you can just pass any js object into the API we don't have to expose them any more.

Comment 3

[Reuben Morais [:reuben]]

Attachment: Don't expose ContactProperties types on window

Comment 4

[Reuben Morais [:reuben]]

Comment on attachment 734157 [details] [diff] [review]
Don't expose ContactProperties types on window

Looks green on Try: https://tbpl.mozilla.org/?tree=Try&rev=c753d6b8a5cc

Comment 5

[Gregor Wagner [:gwagner]]

I think you have to change the uuid as well.

Comment 6

[Reuben Morais [:reuben]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e573a8f7ce1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7cb5c6e47f0

https://tbpl.mozilla.org/php/getParsedLog.php?id=21694009&tree=Mozilla-Inbound

Comment 8

[Reuben Morais [:reuben]]

Apparently it needed a clobber, see bug 860894.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab0974ead030

Comment 9

[Reuben Morais [:reuben]]

Follow-up to fix a UUID mismatch… ಠ_ಠ
https://hg.mozilla.org/integration/mozilla-inbound/rev/59360cb3396f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ab0974ead030
https://hg.mozilla.org/mozilla-central/rev/59360cb3396f

Comment 11

[Kohei Yoshino [:kohei]]

This won't affect site compatibility as the availability of the API is limited.