856629 - Implement ChildNode.remove()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[David Bruant]

Did you mean Element.remove()? If not, could you link to the spec of ChildNode.remove, please, I'm curious :-)

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

<http://dom.spec.whatwg.org/#interface-childnode>. That is, Element/CharacterData/DocumentType.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Import test for select.remove

rs?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Implement ChildNode.remove()

Comment 5

[Mounir Lamouri (:mounir)]

Comment on attachment 734744 [details] [diff] [review]
Part a: Import test for select.remove

Review of attachment 734744 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 6

[Mounir Lamouri (:mounir)]

Comment on attachment 734746 [details] [diff] [review]
Part b: Implement ChildNode.remove()

I am at the SysApps F2F this week and I will have a hard time to dedicate time for this review. Hopefully Boris can do that before me. Otherwise, bounce this back to me.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 734746 [details] [diff] [review]
Part b: Implement ChildNode.remove()

The right spec link is http://dom.spec.whatwg.org/#interface-childnode

r=me with that, assuming you'll add the other form of remove() on <select> in bug 841488.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Boris Zbarsky (:bz) from comment #7)
> assuming you'll add the other form of remove() on <select> in bug 841488.

I did, didn't I?

Comment 9

[Boris Zbarsky [:bzbarsky]]

I didn't look at the patches; just assumed they contain the change.

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/942459e50bd0
https://hg.mozilla.org/mozilla-central/rev/9b71c6c95c6c

Comment 11

[Jean-Yves Perrier [:teoli]]

Docs updated:
https://developer.mozilla.org/en-US/docs/Web/API/ChildNode
https://developer.mozilla.org/en-US/docs/Web/API/ChildNode.remove
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/24