856835 - [FHR] FHR bookmarks not correct

Status: VERIFIED WORKSFORME

(Firefox Health Report Graveyard :: Web: Health Report, defect)

Description

[Annie Elliott]

The vital showed that I had 57 bookmarks. I added 3 more, expecting to see that number jump to 60 after refreshing the health report. It did not:

Vital Stats

    version22.0a1
    time open2 minutes
    last crash2012-10-23
    bookmarks57

Neither did the raw data:

"org.mozilla.places.places": {
          "_v": 1,
          "bookmarks": 57,
          "pages": 25097
        },

T

Comment 1

[Daniel Einspanjer [:dre] [:deinspanjer]]

The report is not live data.  It is based on the last recorded payload.  Check tomorrow and see if the number has gone up.  If it does, then this one bug is likely a works as intended.

Comment 2

[Schalk Neethling [:espressive]]

So, I have added a test to the codebase for bookmarks and it passes as expected with single or multiple sessions.

Comment 3

[Laura Thomson :laura]

Removing unrelated dependencies

Comment 4

[Matt Brandt [:mbrandt]]

QA verified worksforme per comment 1 and comment 2. This feature appears to work as designed.

Comment 5

[Annie Elliott]

 (In reply to Daniel Einspanjer :dre [:deinspanjer] from comment #1)
> The report is not live data.  It is based on the last recorded payload. 
> Check tomorrow and see if the number has gone up.  If it does, then this one
> bug is likely a works as intended.

Just FYI, I looked at my raw data today, and the date is now updated (4/2), but the bookmark count is still 57. I verified that the new bookmarks show up in the bookmarks menu:

{
  "version": 2,
  "thisPingDate": "2013-04-02",
  "geckoAppInfo": {
    "_v": 1,
    "vendor": "Mozilla",
    "name": "Firefox",
    "id": "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}",
    "version": "22.0a1",
    "appBuildID": "20130401030817",
    "platformVersion": "22.0a1",
    "platformBuildID": "20130401030817",
    "os": "Darwin",
    "xpcomabi": "x86_64-gcc3",
    "updateChannel": "nightly"
  },

...

       "org.mozilla.places.places": {
          "_v": 1,
          "bookmarks": 57,
          "pages": 25097
        },
        "org.mozilla.searches.counts": {
          "_v": 2,
          "google.urlbar": 10
        },
        "org.mozilla.appInfo.appinfo": {
          "_v": 2,
          "isBlocklistEnabled": 1,
          "isDefaultBrowser": 1,
          "isTelemetryEnabled": 1
        },
        "org.mozilla.appInfo.versions": {
          "_v": 2,
          "appVersion": [
            "22.0a1"
          ],
          "platformVersion": [
            "22.0a1"
          ],
          "appBuildID": [
            "20130331030859"
          ],
          "platformBuildID": [
            "20130331030859"
          ]
        }
      },
      "2013-03-31": {
        "org.mozilla.searches.counts": {
          "_v": 2,
          "google.urlbar": 3
        },
        "org.mozilla.appSessions.previous": {
          "_v": 3,
          "cleanActiveTicks": [
            1637
          ],
          "cleanTotalTime": [
            125578
          ],
          "main": [
            63
          ],
          "firstPaint": [
            857
          ],
          "sessionRestored": [
            4027
          ]
        }
      },
      "2012-10-23": {
        "org.mozilla.crashes.crashes": {
          "_v": 1,
          "submitted": 1
        }
      }
    }
  },
  "lastPingDate": "2013-04-02"
}

Comment 6

[Daniel Einspanjer [:dre] [:deinspanjer]]

Annie,

I'm seeing consistent data for myself, and the test seems valid, but if you are still seeing incorrect results, I'd like to dig further.

I don't know how QA feels about re-opening verified bugs, so I'll just ask if you can give me a full copy of your latest JSON and healthreport.sqlite via e-mail.  I also want to run a query on your places.sqlite, but don't feel comfortable asking for that, so ping me on IRC and I'll try to get you set up with the necessary SQL to run.

Comment 7

[Annie Elliott]

},
        "org.mozilla.places.places": {
          "_v": 1,
          "bookmarks": 60,
          "pages": 25234
        },

Today they both budged. I am willing to let this go for now. There does seem to be a huge lag though.