857223 - XPCNativeWrapper no longer defined in SeaMonkey feed test

Status: RESOLVED INVALID

(Core :: XPConnect, defect)

Description

[Frank Wein [:mcsmurf]]

Note: I'm filing this bug as unconfirmed as I'm not really sure if this is a valid bug or a bug in one of SeaMonkey's test. I suspect this bug here is related to bholley's work on xpcnativewrapper.unwrap (maybe Bug 855922?).

This SeaMonkey mochitest(-5) test http://hg.mozilla.org/comm-central/annotate/cbb67232177d/suite/browser/test/mochitest/feed_discovery.html#l92 broke a few days ago.
The test broke somewhere in this timeframe http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e4d8e21d0788&tochange=1932c6f78248 (it's only one day long). There are a few checkins by bholley that were related to xpcnativewrapper as far as I see this.
Relevant source code:
"netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
[...]
var browserSH = currentWindow.XULBrowserWindow;
var discovered = browserSH.feeds;
[...]
var feeds = [];
for each (var aFeed in discovered) {
  feeds[XPCNativeWrapper.unwrap(aFeed).href] = true;
}"

Error message is:
XPCNativeWrapper is not defined

I'm not really sure if this is a bug or not, the XPCNativeWrapper.unwrap bit was added quite a while ago to work around some xpconnect assertion (probably no longer needed, so will be removed in Bug 856872). Feel free to mark this bug here as invalid or confirm, I don't know much about XPCNativeWrapper and unwrap. Just wanted to give you a heads-up.

Comment 1

[Frank Wein [:mcsmurf]]

bholley: This bug here might be related to your work on xpcnativewrapper (if it's a valid bug, see Comment 0 for details).

Comment 2

[Bobby Holley (:bholley)]

This is probably because of bug 790732, in which we no longer define Components (and XPCNativeWrapper) in content scopes.

Is this a content scope? If so, XPCNativeWrapper.unwrap should be a no-op.

Comment 3

[Frank Wein [:mcsmurf]]

Yeah, mochitest-5 runs in content scope. ok, got it, invalid then, no real bug :)