857414 - [meta] B2G RIL: Move all icc/sim-related stuff from mozMobileConnection to mozIccManager

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Edgar Chen [:edgar]]

To have a more clear design for mozMobileConnection and mozIccManager, we plan to move all icc/sim-related stuff from mozMobileConnection to mozIccManager as RIL developers have discussed in [1]. And also separate mozIccManager from mozMobileConnection. 

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=782603#c42

Comment 1

[Edgar Chen [:edgar]]

To avoid breaking icc related function, I plan to add icc-related stuff into IccManager but keep mobileConnection API unchanged. I will file another bug for removing those deprecated stuff from MobileConnection after Gaia has applied this new design. Any other good suggestions? :)

Comment 2

[Edgar Chen [:edgar]]

Attachment: Part 1: Put icc related attribute and function into IccManager (IDL), v1

Comment 3

[Edgar Chen [:edgar]]

Attachment: Part 2: Put icc related attribute and function into IccManager (DOM), v1

Comment 4

[Edgar Chen [:edgar]]

Attachment: Part 3: GPS changes, v1

Comment 5

[Edgar Chen [:edgar]]

Attachment: Part 4: Bluetooth changes, v1

Comment 6

[Edgar Chen [:edgar]]

Attachment: Part 5: RIL implementation for new event of IccListener, v1

Comment 7

[Edgar Chen [:edgar]]

Attachment: Part 6: Marionette tests for IccManager, v1

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 732752 [details] [diff] [review]
Part 1: Put icc related attribute and function into IccManager (IDL), v1

Review of attachment 732752 [details] [diff] [review]:
-----------------------------------------------------------------

1.Please discuss with smaug first,
for he's concerns to put icc into navigator in the first place. See Bug 744714 Comment 75.

2. Please break your patches into smaller parts, or make it seperate bugs.
I hope you understand you're changing 'iccinfo', 'card lock', 'card state', 'call forwaring', and these 4 functionalities are heavily used dairy in dogfooding.

3. Remove 'Mobile' in MobileCFInfo, also I would suggest using CallForwardingInfo for a more detail name.

Comment 9

[Edgar Chen [:edgar]]

(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #8)
> Comment on attachment 732752 [details] [diff] [review]
> Part 1: Put icc related attribute and function into IccManager (IDL), v1
> 
> Review of attachment 732752 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> 1.Please discuss with smaug first,
> for he's concerns to put icc into navigator in the first place. See Bug
> 744714 Comment 75.
Ok, I will discuss with :smaug about the naming in navigator.

> 
> 2. Please break your patches into smaller parts, or make it seperate bugs.
> I hope you understand you're changing 'iccinfo', 'card lock', 'card state',
> 'call forwaring', and these 4 functionalities are heavily used dairy in
> dogfooding.
I will try to file separate bug.

> 
> 3. Remove 'Mobile' in MobileCFInfo, also I would suggest using
> CallForwardingInfo for a more detail name.
Good suggestion, thanks

Comment 10

[Edgar Chen [:edgar]]

All bugs are RESOLVED, we could close this meta bug. :)
Thanks, everyone!