857542 - CustomizableUI.registerWindow() isn't always called

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Seems this was added in the initial review, and I missed it... CustomizeMode is calling CustomizableUI.registerWindow(), therefore it only gets called on windows that enter the customization mode. Instead, it needs to be called for every window that has a toolbar/panel that gets built by CustomizableUI.

registerWindow() really just exists to ensure unregisterBuildWindow() gets called when the window closes - that cleans up the internal state of CustomizableUI that keeps track of build areas and widget instances. This was why the original code was hooking that up automatically whenever a build area (toolbar/panel) instance was registered - its cleaning up after those disappear (it's not so much about the window, but whats in the window). I think the intent was to decouple that, but I'm not convinced it should be decoupled.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Ah, yep - I see now. This patch moves the cleanup event handler registration back to when we register the toolbar.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 735340 [details] [diff] [review]
Patch v1

Review of attachment 735340 [details] [diff] [review]:
-----------------------------------------------------------------

Should also:
* remove the public API for registerWindow (don't think it will cause harm by someone calling it, but it's still not an API that should be called by outside code)
* rename registerWindow to registerBuildWindow, so it matches unregisterBuildWindow
* move registerBuildWindow so it's right before unregisterBuildWindow


r+ with those tweaks.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1.1 (r+'d by Unfocused)

Thanks Blair!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Landed on jamun: https://hg.mozilla.org/projects/jamun/rev/dc0040f952a5

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Landed on UX: https://hg.mozilla.org/projects/ux/rev/dc0040f952a5

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/ca22fecd3a71