Closed Bug 857575 Opened 11 years ago Closed 11 years ago

Various UI complaints about the threadpane's header. ;)

Categories

(Thunderbird :: Folder and Message Lists, defect)

18 Branch
All
macOS
defect
Not set
normal

Tracking

(thunderbird22 fixed, thunderbird23 fixed)

RESOLVED FIXED
Thunderbird 23.0
Tracking Status
thunderbird22 --- fixed
thunderbird23 --- fixed

People

(Reporter: bwinton, Assigned: Paenglab)

Details

Attachments

(4 files)

The things which I think need to be lightened up have pink boxes around them.
For the thread indicator, I think we can use the one from the header, for the dots, I would be happy just making them smaller and/or a lighter grey.  (Perhaps the same shade as the down arrow in the second row?)

Thanks,
Blake.
Attached patch patchSplinter Review
This patch makes the dots 4px instead of 6px. I'm also used the lighter thread icons from thread header. Because of this the blue unread thread icons are a little bit thicker to show better their state.
In the column header I used now the old thread icon from treechild to hide the sortdir arrow.
I've also updated the HiDPI icons to follow the LoDPI ones. I could only test with removing the @media (min-resolution: 2dppx) media query on my normal screen and they are looking the same.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #733450 - Flags: ui-review?(bwinton)
Attachment #733450 - Flags: review?(bwinton)
Comment on attachment 733450 [details] [diff] [review]
patch

Looks much better!  ui-r=me!
And there really aren't many code changes, so r=me, too.

Thanks for the quick turnaround!

Mark, can we take this on Aurora?  The new theme makes it quite hard for me to scan the thread pane, and the only files that were changed were pngs, so the risk should be very low.
Attachment #733450 - Flags: ui-review?(bwinton)
Attachment #733450 - Flags: ui-review+
Attachment #733450 - Flags: review?(bwinton)
Attachment #733450 - Flags: review+
Attachment #733450 - Flags: approval-comm-aurora?
Keywords: checkin-needed
Comment on attachment 733450 [details] [diff] [review]
patch

Totally. a=me.
Attachment #733450 - Flags: approval-comm-aurora? → approval-comm-aurora+
https://hg.mozilla.org/comm-central/rev/eba0a4c72282
https://hg.mozilla.org/releases/comm-aurora/rev/70be48dab202
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
Does this change any other platform than OS X?
Can you set the platform fields? Thanks.
OS: All → Mac OS X
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: