857790 - Convert AudioParam time values to ticks relative to the source stream, not the destination stream

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

In ProduceAudioBlock, the stream that we get is the source stream, and the times specified on AudioParam objects are relative to the graph's destination stream.  When converting values to ticks, we currently convert the other way around.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 733041 [details] [diff] [review]
Patch (v1)

Review of attachment 733041 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/WebAudioUtils.cpp
@@ +21,5 @@
>      TrackRate sampleRate = IdealAudioRate();
>  
>      ConvertTimeToTickHelper* This = static_cast<ConvertTimeToTickHelper*> (aClosure);
> +    TrackTicks tick = This->mDestinationStream->GetCurrentPosition();
> +    TrackTicks destinationStreamTime = TicksToTimeRoundDown(sampleRate, tick);

This is a StreamTime, not a TrackTicks.

Comment 2

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8084f411a027

Comment 3

[(no longer active)]

Gah, I messed up and included an unintentional change in my commit.  This fixes it: https://hg.mozilla.org/integration/mozilla-inbound/rev/0673f4718ee2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8084f411a027
https://hg.mozilla.org/mozilla-central/rev/0673f4718ee2

Comment 5

[(no longer active)]

Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.