857853 - mozharness nosetests broken on windows again

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Aki Sasaki (not active)]

For most of the errors, it looked like an issue with the raw log not being closed before starting the next test, resulting in the next test being unable to remove the file.

Comment 1

[Aki Sasaki (not active)]

Attachment: get windows nosetests to pass

I was able to pass ./unit.sh (nosetests) with this patch applied on w64-ix-slave22 with both mercurial==1.7.3 and mercurial==2.5.3.

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 735501 [details] [diff] [review]
get windows nosetests to pass

Review of attachment 735501 [details] [diff] [review]:
-----------------------------------------------------------------

::: test/test_base_script.py
@@ +393,5 @@
>          self.s = script.BaseScript(initial_config_file='test/test.json')
>  
> +    def tearDown(self):
> +        if hasattr(self, 's') and isinstance(self.s, object):
> +            del(self.s)

Can you comment why you need to delete this object?

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 735501 [details] [diff] [review]
get windows nosetests to pass

http://hg.mozilla.org/build/mozharness/rev/b1dbc0f56ff8
with comments.