Closed
Bug 858010
Opened 11 years ago
Closed 11 years ago
Display error in TB 22 using personas
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird22+ fixed)
RESOLVED
FIXED
Thunderbird 23.0
People
(Reporter: 1st.Arwing, Assigned: Paenglab)
References
Details
Attachments
(2 files)
220.96 KB,
image/png
|
Details | |
2.31 KB,
patch
|
mconley
:
review+
mconley
:
ui-review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
The Mail-Toolbar is no longer affected by Personas in TB22. That should be changed.
Assignee | ||
Comment 1•11 years ago
|
||
Bug 817468 regressed this. I think I need to set the background color directly on the attachment bar.
Assignee | ||
Comment 2•11 years ago
|
||
Sorry Mike, I forgot to check Bug 817468 with personas. This patch sets now directly a background color on attachmentBar which looks like setting the -moz-appearance: toolbox; on mailContent or messengerBox. For this I gave under Win7 the background-image.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #734021 -
Flags: ui-review?(mconley)
Attachment #734021 -
Flags: review?(mconley)
Updated•11 years ago
|
tracking-thunderbird22:
--- → +
Comment 3•11 years ago
|
||
Comment on attachment 734021 [details] [diff] [review] proposed fix Sorry for the crazy wait on this. Code looks good, and testing shows that this does indeed fix the problem. Thanks Richard!
Attachment #734021 -
Flags: ui-review?(mconley)
Attachment #734021 -
Flags: ui-review+
Attachment #734021 -
Flags: review?(mconley)
Attachment #734021 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 734021 [details] [diff] [review] proposed fix [Approval Request Comment] Regression caused by (bug #): 817468 User impact if declined: Wrong appearance with LW-themes Risk to taking this patch (and alternatives if risky): small, there are only CSS changes.
Attachment #734021 -
Flags: approval-comm-aurora?
Comment 5•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/ebc5dba345c4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
Updated•11 years ago
|
Attachment #734021 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 6•11 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/a02b40a24fec
status-thunderbird22:
--- → verified
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•