858290 - Need to enable focusmanager.testmode for tests run against B2G desktop builds

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Interacting with the keyboard or select options in the B2G desktop client requires focus on the application unless focusmanager.testmode is enabled in the preferences.

I see a couple of options:

1. Add required preferences to the profile when launching the binary specified in the MarionetteTestRunner. We already set a few preferences here, but we'd be adding focusmanager.testmode and setting these even if a profile is specified. See http://hg.mozilla.org/mozilla-central/file/c232bec6974d/testing/marionette/client/marionette/geckoinstance.py#l20

2. Add a B2GDesktopProfile to mozprofile that specifies this and any other required preferences for the B2G desktop client. This would also likely involve adding a B2GDesktopRunner in mozrunner, and adding a way to determine the binary specified on the command line of MarionetteTestRunner. Perhaps by an --application option, similar to Mozmill.

Comment 1

[Jonathan Griffin (:jgriffin)]

GeckoInstance was designed for desktop Firefox; I wonder how many differences we'll eventually want for B2G desktop builds?  It might make sense to create a B2GDesktopInstance subclass of this which has its own set of prefs that get used even when you specify a profile.

I like that approach better than adding classes to mozprofile/mozrunner, since it's a lot lighter-weight.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Sounds good to me. How would you suggest we determine the class to use? Should we inspect the binary specified or just have an --application option?

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Set focusmanager.testmode for B2G desktop. v1.0

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 733840 [details] [diff] [review]
Set focusmanager.testmode for B2G desktop. v1.0

Review of attachment 733840 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thanks.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f719ebae709

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2f719ebae709

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Thanks, can we get this uplifted to b2g18?

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

this looks to be an a=testonly since it's a patch to marionette - anything i'm missing here?

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed as:
https://hg.mozilla.org/releases/mozilla-b2g18/rev/fbbf1d226f45

Comment 10

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/1198ae654986