Closed
Bug 858671
Opened 11 years ago
Closed 11 years ago
do_GetAtom is fallible, but consumers assume it's not
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
4.53 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
As far as I can tell, many consumers of do_GetAtom assume it's infallible, whereas in practice it can return null. Should we just make this infallible?
(In reply to Boris Zbarsky (:bz) from comment #0) > Should we just make this infallible? Yes.
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #733990 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → bzbarsky
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [need review]
Attachment #733990 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d37a93af33a8
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla23
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d37a93af33a8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•