858929 - External components can't register memory reporters

Status: RESOLVED FIXED

(Core :: DMD, defect)

Description

[[e-mail]]

Although nsIMemoryReporter.idl goes out of its way to use the string glue instead of the internal string API, it doesn't export its entry points, so it can't be used externally.

Comment 1

[[e-mail]]

Attachment: Proposed patch

This works for me on Linux; I'm testing it on Windows too.

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 734238 [details] [diff] [review]
Proposed patch

Review of attachment 734238 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me;  I've never seen XPCOM_API before but I can believe it works.

Did you need to do this for a particular case, or is it just something you noticed?

Comment 3

[[e-mail]]

(In reply to Nicholas Nethercote from comment #2)
> Did you need to do this for a particular case, or is it just something you
> noticed?

When Gecko 4 landed, it wasn't possible to build Thunderbird using either of the traditional methods (shared or static), only libxul was supported.

Unfortunately most of the mailnews codebase was written using the internal API, which is only available to modules within libxul, so a cheesy hack was written whereby the mailnews codebase was linked into libxul.

However there have been various efforts to get mailnews to build as a binary component. This would for instance allow it to be a xulrunner application.

In order for this to work, all functions that it needs either need to be on interfaces or exported from xpcom or libxul using the XPCOM_API annotation.

Joshua Cranmer recently added a memory reporter to Thunderbird and for it to continue to compile as a binary component it needs to be able to link to those functions, which is why they will need the XPCOM_API annotation.

Comment 4

[[e-mail]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcd43a7b4b98

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fcd43a7b4b98