858998 - Top Sites should use two strings in Browser

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P3)

Description

[Théo Chevalier]

Currently, the Top Sites string on the start page and the one on the tab menu are the same string. This is an issue at least for French. On Android we are using "Les plus visités" on the start page and "Les + visités" on the tab menu.

On Firefox OS, as we have even less space, we want to use "Les plus visités" on the start page and "+ visités" on the tab menu. (We currently have "Les plus…" on the tab, which is really meaningless.)

The solution I see is simply to use two different strings.
If French is the only affected locale, we can just land that on master.

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Pointer to GH

Comment 2

[Fabien Cazenave [:kaze]]

Comment on attachment 765478 [details]
Pointer to GH

Thank you Theo for the bug report!

Sorry to bikeshed, but I’d prefer to have two new strings in order to let our l10n contributors know that they can update their translation, and possibly provide a more readable string for the start page if they had to shorten it to make it fit in the tab. Adding a localization note might help, too — e.g.:

  # LOCALIZATION NOTE: depending on your locale, you might want to use a more
  # compact translation for top-sites-tab than for top-sites-startPage.
  top-sites-startPage = Top sites
  top-sites-tab       = Top sites

Dale, please r? me again. Thanks!

Comment 3

[Dale Harvey (:daleharvey)]

Comment on attachment 765478 [details]
Pointer to GH

Updated commit with feedback from previous review

Comment 4

[Dale Harvey (:daleharvey)]

Merged in: https://github.com/mozilla-b2g/gaia/commit/cd1634c45c6b0e3335c240cdfc1e6794d8ef5fbf

Cheers Kaze