859125 - Clean up confvars.sh and configure.in

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Joshua Cranmer [:jcranmer]]

+++ This bug was initially created as a clone of Bug #846540 +++

@@ +92,5 @@
> +AC_SUBST(LDAP_CFLAGS)
> +AC_SUBST(LDAP_LIBS)
> +
> +# Rerun the confvars, since we need to add to our components list.
> +. "${srcdir}/${MOZ_BUILD_APP}/confvars.sh"

I'd rather move to here, the stuff we *need* to do after these magic lines run from confvars.sh. Now that we have the app-specific configure.in so that we can avoid the re-run of confvars.sh (re-entrancy makes for poor bed fellows there)

Comment 1

[[e-mail]]

Attachment: WIP

This is the minimum necessary to get external builds working. Please let me know if there is any other cleanup that you were thinking of that I can include.

Comment 2

[[e-mail]]

I mean external API, of course.

The problem with the current code is that the external API flag isn't set the first time confvars.sh runs, so the toolkit build always gets set up for internal components.

Comment 3

[[e-mail]]

Comment on attachment 740760 [details] [diff] [review]
WIP

I couldn't find any useless use of AC_SUBST, so the patch remains unchanged.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 740760 [details] [diff] [review]
WIP

Looks good. r=Standard8.

Comment 5

[[e-mail]]

Pushed comm-central changeset 50dcb67013a5.