859295 - Null Media as a clip behaves incorrectly on the timeline

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Chris DeCairos (:cade)]

STR:

1. Add "#t=,35" as a media clip, and then add it to the timeline as an event
2. Move it around, resize it however you please.

Expected: should behave like any other media clip.
Actual: It's size changes to values you did not set. eventually it's view can disappear altogether and it will have negative start values and massive end times ( >10 hours) I've also seen it affect the times of other media clips on the timeline.

We should just prevent the adding of null media clips completely, because they're useless.

Comment 1

[Brett Gaylor [:brett]]

agreed, you shouldn't be able to do that (though I don't think anyone would as it isn't exposed in the interface)

Comment 2

[Scott [:thecount] Downe]

Some updated STRs:

1. drop a null media clip that is smaller than the main media's duration.
2. change the end time to be greater than the initial end time.

Expected: Enforce track event duration.
Actual: Crazy town.

Comment 3

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/butter/pull/1655

Comment 4

[Chris DeCairos (:cade)]

Comment on attachment 734626 [details]
https://github.com/mozilla/butter/pull/1655

nice, simple fix. Man, it's easy to get burned by data types in JS.

R+

Up to you if you think a second review is warranted.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 734626 [details]
https://github.com/mozilla/butter/pull/1655

SR?

Comment 6

[Matthew Schranz [:mjschranz]]

Comment on attachment 734626 [details]
https://github.com/mozilla/butter/pull/1655

My only question is why we are allowing null media to be added as clips period. It doesn't have any use case as far as I can tell. I'm personally in favor of removing it completely from the getMetaData portion of the MediaUtil API.

Thoughts?

Comment 7

[Scott [:thecount] Downe]

Comment on attachment 734626 [details]
https://github.com/mozilla/butter/pull/1655

I don't think it is worth worrying about it. It does no harm.

If you really want it gone, could we do it in a new ticket?

I would R+ it.

Comment 8

[Matthew Schranz [:mjschranz]]

Comment on attachment 734626 [details]
https://github.com/mozilla/butter/pull/1655

Fine.

See #862348.

Comment 9

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/butter/commit/9fe07090cef5034f1a6e8fc29be9767a74568661