859418 - [MP] Defect - Browser branding links should point to valid pages

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: patch v1

Links on the 'about:' page are constructed using '%APP%', which means we create URLs like this:
  http://www.mozilla.org/en-US/projects/metrofirefox/

These will 404 because they are not real pages.

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 734720 [details] [diff] [review]
patch v1

Jimm: I'm not sure who an appropriate reviewer would be for this patch, but you seem the most likely candidate out of us metro hackers.  Let me know if I should forward this to someone else.  Thanks!

Comment 2

[Jim Mathies [:jimm]]

(In reply to Tim Abraldes (:tabraldes) (:TimAbraldes) from comment #0)
> Created attachment 734720 [details] [diff] [review]
> patch v1
> 
> Links on the 'about:' page are constructed using '%APP%', which means we
> create URLs like this:
>   http://www.mozilla.org/en-US/projects/metrofirefox/
> 
> These will 404 because they are not real pages.

I think we might want some of these to work but the pages haven't been created. We can update them to point to fx resources but we should have a bug filed on getting all of these set correctly before we roll out on the train for the first time.

Maybe the a good next step would be to file a bug and post a list of all the support related urls we use like this and cc in asa. Some of these we might want to point to existing fx pages, some we might want to custom pages for.

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 734720 [details] [diff] [review]
patch v1

Review of attachment 734720 [details] [diff] [review]:
-----------------------------------------------------------------

No harm in updating them to point to fx locations for now.

Comment 4

[Jim Mathies [:jimm]]

Alternatively, mark this with leave-open and make sure it's blocking v1 release.

Comment 5

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: patch v2

This patch keeps the branding changes but doesn't include the change to metro.js.  I've filed bug 859903 for cleaning up metro.js.

Comment 6

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

I'm running this through try:
  https://tbpl.mozilla.org/?tree=Try&rev=27c7aacc77c7

I'll test the build output, and if it works as expected I'll land the 3 patches together

Comment 7

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Landed on inbound:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/08f54c265a09


Note: This bug should remain open.  Before launch, we'll want to decide for each URL whether we actually want to use the regular Firefox page or create a new page with metro-specific content.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/08f54c265a09

Comment 9

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Unassigning myself since the desktop dev work is complete.  Any remaining work will be server-side (creating 'metrofirefox' specific pages)

Comment 10

[Brian R. Bondy [:bbondy]]

p=1

Comment 11

[Jim Mathies [:jimm]]

Looking over the original branding links - 

not used:
startup.homepage_override_url
startup.homepage_welcome_url
app.update.url.details

used:
app.update.url.manual - https://www.mozilla.org/firefox/

I think this can be closed out. The only link left is the download link, which seems fine as is.

Comment 12

[Jim Mathies [:jimm]]

Current about comps don't have an update details link either - 

https://bug898843.bugzilla.mozilla.org/attachment.cgi?id=782721