860050 - Remove non-namespaced JSHandle names

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

These are for legacy C compatibility. I expect this is thoroughly rotted by now. If anyone needs them later, they can easily re-add them in the c-api wrapper's header.

Comment 1

[Terrence Cole [:terrence]]

Attachment: JSRawObject; 1of2; v0

This patch was generated by running the following two command:
find js/ -name "*.cpp" -or -name "*.h" | xargs sed -i 's/JSRawObject /JSObject */g'
find . -name "*.cpp" -or -name "*.h" | xargs sed -i 's/JSRawObject/JSObject*/g'

Ack confirms that there are no more references. A follow-up removes the definition and the one place where the above simple script does not work.

Comment 2

[Terrence Cole [:terrence]]

Attachment: JSRawObject; 2of2; v0

I will fold this with the first before pushing.

Try run is green:
https://tbpl.mozilla.org/?tree=Try&rev=58c10c995baa

Comment 3

[Terrence Cole [:terrence]]

Attachment: JSRawString; 1of1; v0

Removed manually since there were only 5 occurrences.

Comment 4

[Terrence Cole [:terrence]]

Attachment: JSRaw*; 1of1; v0

Trivial: the rest of the JSRaw have no uses.

Comment 5

[Terrence Cole [:terrence]]

Attachment: JSMutableHandleId; 1of1; v0

Comment 6

[Terrence Cole [:terrence]]

Attachment: JSMutableHandleScript; 1of1; v0

Comment 7

[Terrence Cole [:terrence]]

Attachment: JSMutableHandleObject; 1of3; v0

Generated with the script:
> find js/src/jsapi-tests/ -name "*.cpp" | xargs sed -i 's/JSMutableHandleObject/JS::MutableHandleObject/g'
> find js/ -name "*.py" -or -name "*.h" | xargs sed -i 's/JSMutableHandleObject/JS::MutableHandleObject/g'
> find js/ -name "*.cpp" | xargs sed -i 's/JSMutableHandleObject/MutableHandleObject/g'

Comment 8

[Terrence Cole [:terrence]]

Attachment: JSMutableHandleObject; 2of3; v0

Remove JSMutableHandleObject typedef manually rather than complicating the script. Will fold before pushing.

Comment 9

[Terrence Cole [:terrence]]

Attachment: JSMutableHandleObject; 3of3; v0

This is the browser portion of the name change. It was generated with the following command:
> find . -name "*.py" -or -name "*.h" -or -name "*.cpp" | xargs sed -i 's/JSMutableHandleObject/JS::MutableHandle<JSObject*>/g'

Comment 10

[Terrence Cole [:terrence]]

https://tbpl.mozilla.org/?tree=Try&rev=79bcfab5a037

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 738251 [details] [diff] [review]
JSMutableHandleObject; 3of3; v0

r=me

Comment 12

[Paul Wright]

Any more to do here?

Comment 13

[Terrence Cole [:terrence]]

Green try run at:
https://tbpl.mozilla.org/?tree=Try&rev=263ce8d8cb07

Pushed at:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4581bea1b9cf
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb5c1c2c413e
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee10fbf0d59b
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1846cf42c9b
https://hg.mozilla.org/integration/mozilla-inbound/rev/c996a9ace58c
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3516be5f0b8

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4581bea1b9cf
https://hg.mozilla.org/mozilla-central/rev/bb5c1c2c413e
https://hg.mozilla.org/mozilla-central/rev/ee10fbf0d59b
https://hg.mozilla.org/mozilla-central/rev/c1846cf42c9b
https://hg.mozilla.org/mozilla-central/rev/c996a9ace58c
https://hg.mozilla.org/mozilla-central/rev/b3516be5f0b8