Closed Bug 860406 Opened 11 years ago Closed 11 years ago

When using Personas on Mac, the title bar is overlaid by the tab bar

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird22+ fixed, thunderbird23+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 23.0
Tracking Flags:
Tracking Status
thunderbird22 + fixed
thunderbird23 + fixed

People

(Reporter: standard8, Assigned: Paenglab)

References

Details

(Keywords: regression)

Attachments

(2 files)

Screenshort of overlap
15.31 KB, image/png
Details
proposed fix
992 bytes, patch
mconley
: review+
mconley
: ui-review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review
Attached image Screenshort of overlap — 
When runnning with Personas on Mac, the tab bar goes up and over the title bar. If you run with the default theme, then everything is as expected with the tab bar underneath the title bar.
Attached patch proposed fix — — Splinter Review 
This is because we don't use the titlebar vbox under OS X. I'm still waiting for the finished Firefox draw in titlebar implementation to port it to TB. This patch is a workaround until we can port the end solution. FX also used sometime this approach. So it's not really a hack.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #736154 - Flags: ui-review?(mconley)
Attachment #736154 - Flags: review?(mconley)
Comment on attachment 736154 [details] [diff] [review]
proposed fix

Yep, totally. Thanks Richard!
Attachment #736154 - Flags: ui-review?(mconley)
Attachment #736154 - Flags: ui-review+
Attachment #736154 - Flags: review?(mconley)
Attachment #736154 - Flags: review+
Comment on attachment 736154 [details] [diff] [review]
proposed fix

This is a super-safe take for comm-aurora.
Attachment #736154 - Flags: approval-mozilla-aurora?
Keywords: checkin-needed
Attachment #736154 - Flags: approval-mozilla-aurora? → approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/b30782c12707
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-thunderbird23: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
Attachment #736154 - Flags: approval-comm-aurora? → approval-comm-aurora+
Blocks: 876710
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: