Closed Bug 860525 Opened 11 years ago Closed 11 years ago

fireplace ratings DOM nodes have broken 'id="review-"' attributes

Categories

(Marketplace Graveyard :: Consumer Pages, defect)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-04-18

People

(Reporter: spasovski, Assigned: spasovski)

Details

(Whiteboard: [fireplace] p=1) 

This is invalid HTML and the root cause is the missing `id` key on the ratings object used in the template as {{ this.id }}.

These IDs in general are most likely no longer necessary.
Assignee: nobody → dspasovski
Whiteboard: [fireplace] p=1
I thought a saw a patch for this?
Target Milestone: --- → 2013-04-18
fixed as part of: https://github.com/mozilla/fireplace/commit/3cffc2a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.