860779 - Two-finger horizontal swipe disabled as of 2013-04-11 mozilla-central nightly

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Steven Michaud [:smichaud] (Retired)]

We recently landed support for swipe animation in bug 678392.  But this support is turned off by default, and doing this (very unfortunately) seems to turn off our support for swiping altogether.

We need to scramble to find a way to turn off swipe animation without turning off support for swiping altogether.

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Patch

Comment 2

[Stephen A Pohl [:spohl]]

Attachment: Patch

Corrected misspelling in commit message, removed trailing white space and added comment to HSA_Init for the scenario when no snapshots are being taken/stored.

Comment 3

[Stephen A Pohl [:spohl]]

Attachment: Patch

No, really remove trailing white space now.

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 736376 [details] [diff] [review]
Patch

Looks fine to me.

And I tested it briefly on OS X 10.7.5, with browser.snapshots.limit set to '0' (the default) and to '5'.  I saw no problems:  You get swiping without animation with the former setting, and swiping with animation with the latter setting.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2943880a742

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2943880a742