860831 - fix the taloserror handling when we process a crash

Status: RESOLVED WORKSFORME

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

from tbpl logs:
0x662e3000 - 0x66333fff  libnssckbi.so (deleted)  ???

    main()
  File "run_tests.py", line 328, in main
    run_tests(parser)
  File "run_tests.py", line 277, in run_tests
    talos_results.add(mytest.runTest(browser_config, test))
  File "/builds/panda-0821/talos-data/talos/ttest.py", line 404, in runTest
    self.cleanupAndCheckForCrashes(browser_config, profile_dir, test_config['name'])
  File "/builds/panda-0821/talos-data/talos/ttest.py", line 170, in cleanupAndCheckForCrashes
    raise talosCrash()
TypeError: __init__() takes exactly 2 arguments (1 given)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

this would make a good first bug.

Comment 3

[Vaibhav (:vaibhav1994)]

Can I take up this bug?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

this might not even be a bug anymore- yes, please take a look at this and see if it still happens.  You can get talos running and kill the process to invoke a crash.  I believe on linux it is 'kill -ABRT <pid>'