Closed Bug 860851 Opened 11 years ago Closed 11 years ago

New Error Console Filter textbox label should have slightly less useless access key

Categories

(SeaMonkey :: UI Design, defect)

Product:
SeaMonkey
Component:
UI Design
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.18 unaffected, seamonkey2.19 fixed, seamonkey2.20 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.20
Tracking Flags:
Tracking Status
seamonkey2.18 --- unaffected
seamonkey2.19 --- fixed
seamonkey2.20 --- fixed

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: late-l10n)

Attachments

(1 file)

Possible patch
1.14 KB, patch
philip.chee
: review+
iannbugzilla
: review+
iannbugzilla
: approval-comm-aurora+
Details | Diff | Splinter Review 
Bug 801266 added a new label next to the Error Console's Filter textbox. However the accesskey that we previously added in bug 800096 isn't among the letters of the label, so it displays as Filter (K): instead.
Attached patch Possible patch — — Splinter Review 
"i" being the only letter of "Filter" that isn't currently in use. ("l" and "r" are the only other possible candidates, but are currently used by "Clear" and "Errors" respectively.)
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #736412 - Flags: review?(philip.chee)
Attachment #736412 - Flags: review?(iann_bugzilla)
Comment on attachment 736412 [details] [diff] [review]
Possible patch

yeah agreed.
Attachment #736412 - Flags: review?(philip.chee) → review+
Pushed comm-central changeset 10a64867756e.
status-seamonkey2.18: --- → unaffected
status-seamonkey2.19: --- → unaffected
status-seamonkey2.20: --- → fixed
Keywords: late-l10n
Target Milestone: --- → seamonkey2.20
Bah, try again with those tracking flags :s
status-seamonkey2.19: unaffected → affected
Comment on attachment 736412 [details] [diff] [review]
Possible patch

[Approval Request Comment]
Regression caused by (bug #): 801266
User impact if declined: Ugly access key
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: Yes, but already posted to l10n newsgroup
Attachment #736412 - Flags: approval-comm-aurora?
Attachment #736412 - Flags: review?(iann_bugzilla)
Attachment #736412 - Flags: review+
Attachment #736412 - Flags: approval-comm-aurora?
Attachment #736412 - Flags: approval-comm-aurora+
Bah, this time I got the status wrong. Sigh...
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: