Closed
Bug 861192
Opened 11 years ago
Closed 11 years ago
gcli addon command shows [object Object] instead of a list of addons
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: freddy, Assigned: sykopomp)
Details
Attachments
(1 file, 1 obsolete file)
13.96 KB,
patch
|
miker
:
review+
|
Details | Diff | Splinter Review |
I opened the gcli (Shift+F2) and typed "addon list". Expected Result: a list of all addons. Actual Result: The string "[object Object]" was displayed
Reporter | ||
Updated•11 years ago
|
Summary: gcli addon command broken? → gcli addon command shows [object Object] instead of a list of addons
Assignee | ||
Comment 2•11 years ago
|
||
This should revive the command -- I took the chance to split it into a command and a converter, and putting a bit of spit and polish on the listing itself. Once bug 855124 lands, I'd like to also add a Prefs button to the listing, which should be simple and quick. A simpler fix could've been to just add returnType: "view" to the command, but that would be boring! :) (but doable if requested) Joe: I might owe you test cases for this. Still trying to figure out how tests work, and try access is still not quite there (relevant bug reopened, hopefully it was just my mistake)
Comment 3•11 years ago
|
||
Comment on attachment 737812 [details] [diff] [review] reviving and modernizing addon list Review of attachment 737812 [details] [diff] [review]: ----------------------------------------------------------------- I'm holding Mike up on a bug, and he originally wrote the add-on command, so I'm going to bounce the r? to him.
Attachment #737812 -
Flags: review?(jwalker) → review?(mratcliffe)
Comment 4•11 years ago
|
||
Comment on attachment 737812 [details] [diff] [review] reviving and modernizing addon list Review of attachment 737812 [details] [diff] [review]: ----------------------------------------------------------------- This looks excellent and the refactoring was very welcome. The test still passes fine so there is nothing for you to do there: ./mach mochitest-browser browser/devtools/commandline/test/browser_cmd_addon.js The one problem is that if you use the enable / disable buttons on an addon that has no version number (e.g. Shockwave Flash) then the addon name in the commandline has an extra _ so it fails to disable: addon disable Shockwave_Flash_ Once you fix that I will give you an r+.
Attachment #737812 -
Flags: review?(mratcliffe)
Assignee | ||
Comment 5•11 years ago
|
||
Oops! Good catch, and thanks for the mochitest incantation, I meant to ask how to do that. :)
Attachment #737812 -
Attachment is obsolete: true
Attachment #738448 -
Flags: review?(mratcliffe)
Comment 6•11 years ago
|
||
Comment on attachment 738448 [details] [diff] [review] v2 Review of attachment 738448 [details] [diff] [review]: ----------------------------------------------------------------- Magnifico, r+
Attachment #738448 -
Flags: review?(mratcliffe) → review+
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a7e584370ab9
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a7e584370ab9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•