Closed Bug 861372 Opened 11 years ago Closed 11 years ago

get rid of checks for FPU_IS_ARM_FPA

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: froydnj, Unassigned)

Details

Attachments

(1 file)

We only ever check whether it's defined, and no headers or configury sets it.

Archaeology suggests that it used to be defined in jsnum.h, but an Executive Decision was made to only support VFP.  (A good decision!)
Attachment #736961 - Flags: review?(mrosenberg)
Comment on attachment 736961 [details] [diff] [review]
delete checks for FPU_IS_ARM_FPA

Review of attachment 736961 [details] [diff] [review]:
-----------------------------------------------------------------

I seem to remember that I got this macro from the methodjit.  Have you checked if it is used there?
Attachment #736961 - Flags: review?(mrosenberg) → review+
(In reply to Marty Rosenberg [:mjrosenb] from comment #2)
> I seem to remember that I got this macro from the methodjit.  Have you
> checked if it is used there?

grep says these three places were the only occurrences left in the tree.

https://hg.mozilla.org/integration/mozilla-inbound/rev/175149690cbb
https://hg.mozilla.org/mozilla-central/rev/175149690cbb
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: