Closed
Bug 861528
Opened 11 years ago
Closed 11 years ago
$user->can_enter_product() now returns the product object instead of 1
Categories
(Bugzilla :: Documentation, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
1.28 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
In bug 22353, $user->can_enter_product() has been changed to return the product object instead of 1 when the user can enter it. But the POD still says that this method returns 1 on success. As this method is used in security checks, it's important that the documentation remains accurate. This affects Bugzilla 4.0 and newer.
Assignee | ||
Comment 1•11 years ago
|
||
Asking glob as he reviewed the original patch. :)
Comment on attachment 737144 [details] [diff] [review] patch, v1 r=glob
Attachment #737144 -
Flags: review?(glob) → review+
Assignee | ||
Updated•11 years ago
|
Flags: approval?
Flags: approval4.4+
Flags: approval4.2+
Flags: approval4.0+
Flags: approval+
Assignee | ||
Comment 3•11 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/User.pm Committed revision 8610. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/ modified Bugzilla/User.pm Committed revision 8543. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/ modified Bugzilla/User.pm Committed revision 8204. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/ modified Bugzilla/User.pm Committed revision 7751.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•